1519376 - Text wrapping issue in the detail page of the extension

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[CosminB]

Attachment: Bug.png

[Affected versions]:

• Firefox 66.0a1 (20190111093148)
• Firefox 65.0b9 (20190107180200)
• Firefox 64.0.2 (20190108160530)

[Affected platforms]:

• Win 7 64-bit
• Mac OS X 10.13.3

[Steps to reproduce]:
1.Install https://addons.mozilla.org/en-US/firefox/addon/dark-background-light-text/
2.Navigate to Extensions from about:addons page.
3.Click on the extension to see the detail page.
4.Observe the description section.

[Expected results]:

• The text is wrapped correctly in the description section.

[Actual results]:

• A small portion of the text has wrapping issues in the description section.

Please see the attached screenshot.

Comment 1

[Mark Striemer [:mstriemer]]

Adding word-wrap: break-word; should to the #detail-fulldesc element should fix this.

Comment 2

[Andreas Wagner [:TheOne] [use NI]]

This could be a good first bug.

Comment 3

[Ryan Wade]

I am a first time contributor, and I see how to fix this bug, but where exactly to I make the pull request for the source code from? That is such a newbie question but any help is appreciated.

Comment 4

[Shivam Singhal [ :championshuttler ]]

Hi Ryan , are you working on it? If not can i take this up? I build the firefox and setup mercurial as well.

Thanks

Comment 5

[Ryan Wade]

Sure you can take it up Shivam. I have not been able to get a working build of firefox yet. Thanks for checking!

Comment 6

[Ryan Wade]

(In reply to Shivam Singhal [ :championshuttler ] from comment #4)

Hi Ryan , are you working on it? If not can i take this up? I build the firefox and setup mercurial as well.

Thanks

Sure you can take it up Shivam. I have not been able to get a working build of firefox yet. Thanks for checking!

Comment 7

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1519376 - Fixes text wrapping issues in extension detail page. r=mstriemer

Comment 8

[Shivam Singhal [ :championshuttler ]]

Attachment: After.png

Comment 9

[Shivam Singhal [ :championshuttler ]]

Attachment: Before.png

Comment 10

[Mark Striemer [:mstriemer]]

Sorry I missed your needinfo request, Ryan.

There is documentation for getting Firefox setup [1], you can use an artifact build for changes like this. Once you have a patch you will need to submit it to phabricator for review. There is documentation [2] for that too, I think you'll need to complete the steps up to "Submitting Patches" and you'll probably want to use arc for now. I don't have any experience with moz-phab but you can give it a try if you'd like.

Let me know if there's anything else I can help with!

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
[2] https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1818b96796ae
Fixes text wrapping issues in extension detail page. r=mstriemer,Gijs

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1818b96796ae

Comment 13

[CosminB]

Attachment: Bug1519376.png

This issue is verified as fixed on Firefox 67.0a1 (20190212095015) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Hi, I'm happy to take this fix in beta 66 if you can request beta uplift.

Comment 15

[Mark Striemer [:mstriemer]]

Comment on attachment 9042764 [details]
Bug 1519376 - Fixes text wrapping issues in extension detail page. r=mstriemer

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

Long unbroken lines will extend beyond the card in about:addons.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Simple one-line CSS change

String changes made/needed

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9042764 [details]
Bug 1519376 - Fixes text wrapping issues in extension detail page. r=mstriemer

CSS fix, ok for beta 10.

Comment 17

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/690a467b10e1

Comment 18

[CosminB]

This issue is verified as fixed on Firefox 66.0b10 (20190221160854) under Win 7 64-bit and Mac OS X 10.14.1.