Slack's "--- Today ---" header doesn't scroll off screen when WebRender is enabled

RESOLVED FIXED in Firefox 66

Status

()

defect
P2
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: cpeterson, Assigned: kvark)

Tracking

(Blocks 1 bug, {regression})

unspecified
mozilla66
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 unaffected, firefox66 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

This bug is a regression from WebRender bug 1518605.

STR:

  1. Enable WebRender
  2. Load mozilla.slack.com
  3. In a channel with some history, scroll back through the history

RESULT:
The "--- Today ---" or "--- Yesterday ---" banner stays on screen, hovering over the chat text, instead of scrolling off screen.

I bisected this regression to this pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5420c29d49d60862617a6b0014548eb1c7c814f3&tochange=bd59070a24d72da867cf1531e89e75ffed2848ae

Flags: needinfo?(dmalyshau)
Assignee: nobody → dmalyshau
Priority: -- → P2
Assignee

Comment 1

5 months ago

Thanks for finding regression! I'll start looking at it now.

Flags: needinfo?(dmalyshau)
Assignee

Comment 2

5 months ago
This is a follow-up fix to https://github.com/servo/webrender/pull/3251
Accidentally, the reference frame relative offset was applied twice.

Comment 3

5 months ago
Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/078e5984f999
WR fix scroll frame rectangle r=gw

Comment 4

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.