Convert test_TelemetryScalars.js to use TelemetryTestUtils for getParentProcessScalars

RESOLVED FIXED in Firefox 66

Status

()

P3
normal
RESOLVED FIXED
a month ago
29 days ago

People

(Reporter: chutten, Assigned: vdey, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

a month ago

Thanks to bug 1518152 we now have a TelemetryTestUtils module that contains some common test code. test_TelemetryScalars.js should be changed to use the common code instead of its own getParentProcessScalars implementation.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
  3. Start working on this bug. You'll be working in the test_TelemetryScalars.js file, replacing its own getParentProcessScalars with calls to TelemetryTestUtils.getParentProcessScalars. The function signatures are slightly different, so we'll need to add Ci.nsITelemetry.DATASET_RELEASE_CHANNEL_OPTOUT to most calls.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/components/telemetry/tests/test_TelemetryScalars.js. Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
(Assignee)

Comment 1

a month ago

Is this anyway related to Bug 1519480? I wouldn't mind working on it if these two are similar.

(Reporter)

Updated

a month ago
Assignee: nobody → varundey20
Status: NEW → ASSIGNED
(Reporter)

Updated

a month ago
Priority: -- → P3
(Assignee)

Comment 2

a month ago

Created attachment 9037685 [details]
Bug 1519476 - Change reference of getParentProcessScalars to TelemetryTestUtils

Changed the reference of getParentProcessScalars in test_TelemetryScalars.js

Attachment #9037685 - Attachment description: Fix 1519476 Change reference of getParentProcessScalars to TelemetryTestUtils → Bug 1519476 - Change reference of getParentProcessScalars to TelemetryTestUtils

Comment 3

a month ago
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/480c81578390
Change reference of getParentProcessScalars to TelemetryTestUtils r=chutten

Comment 4

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
https://hg.mozilla.org/projects/cedar/rev/480c8157839021de247ead74bffb60ffb5c70a8c
Bug 1519476 - Change reference of getParentProcessScalars to TelemetryTestUtils r=chutten
You need to log in before you can comment on or make changes to this bug.