1519487 - No value for "User Namespaces" in about:support

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P2)

Description

[Viktor Jägersküpper]

In current Firefox Nightly on Linux (64 bit), when I look at the
"Sandbox" part in about:support, there is no value for "User Namespaces"
(used to be "false" if I remember correctly).

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

It looks like the behavior of $.new changed slightly with the conversion to Fluent in bug 1507595, and passing false as a boolean for the second argument gives an empty element (but true is still converted to a string).

The fix is simple.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1519487 - Explicitly convert about:support#sandbox properties to strings.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

From the comments in https://phabricator.services.mozilla.com/D16519, it sounds like someone who's more familiar with aboutSupport.js should handle this.

Comment 4

[:Gijs (he/him)]

(In reply to Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧ from comment #3)

From the comments in https://phabricator.services.mozilla.com/D16519, it sounds like someone who's more familiar with aboutSupport.js should handle this.

Sadly, phab doesn't CC reviewers on bugs so I didn't see this comment... I'll see about fixing this tomorrow or Mon/Tue...

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1519487 - fix display of `false` and other falsy values in about:support when passed to $.new, r?jaws

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f69488e75f13
fix display of `false` and other falsy values in about:support when passed to $.new, r=jaws

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f69488e75f13