1519517 - Don't animate window maximize / resizes when restoring session

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Configure Firefox to restore sessions on start-up
2. Open a few windows, and maximize one of them (when I reproduced this bug, it was the last window I opened that I maximized)
3. Quit the browser
4. Start the browser

ER:

The windows from the last session should be opened, but none should animate.

AR:

The maximized window is opened, and then animates itself into the maximized state.

I only tried reproducing this on macOS, but this might also affect Windows and Linux.

Setting the [fxperf] flag because this is the sort of thing that can impact perceived start-up time.

Comment 1

[Mike de Boer [:mikedeboer]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)

Setting the [fxperf] flag because this is the sort of thing that can impact perceived start-up time.

It does indeed, certainly on OSX. We do set dwu.suppressAnimation(true);, which I think you added, but it doesn't seem to do anything in Cocoa widget code.

Comment 2

[Itiel]

Not sure if related, but on my Windows 10 usually restoring a session opens Nightly as maximized, goes to unmaximized and then maximizes again.
I'm almost always using Nightly in a maximized state.

Comment 3

[Emma Malysz]

Attachment: Bug 1519517, ensure that restoring a session doesn't animate and resize the window

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9697456a48b3
ensure that restoring a session doesn't animate and resize the window r=mstange

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9697456a48b3

Comment 6

[Oana Botisan, Desktop QA]

I can't seem to be able to reproduce this issue.
Can you please post a gif with the issue or verify to see if the issue is reproducing on latest Nightly or beta?

Comment 7

[Emma Malysz]

Attachment: Animate.mov