Flexbox: Distinct color for Min/Max in diagram and info chart

RESOLVED FIXED in Firefox 69

Status

enhancement
P2
normal
RESOLVED FIXED
7 months ago
2 months ago

People

(Reporter: victoria, Assigned: tgerard79, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

It would be helpful to have an extra color to color-code min-max.

Heading, label, label line, lock icon: Purple 60 #8000d7

This updated screen shows how it would look https://mozilla.invisionapp.com/share/MZNA228P5WB#/328646784_flexbox_Item_Examples

I think this is worth uplifting, if possible.

Assignee: nobody → gl
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P2

Thanks Victoria, Gabriel said he'd take a look at it.

Assignee: gl → nobody
Mentor: gl
Status: ASSIGNED → NEW
Keywords: good-first-bug

Hi! I'm an outreachy applicant. Can I take this up? :)

Hi, I'm an outreachy applicant, if this bug is still available, it would be great to have it assigned to me. (in case previous requester had another bug assigned to them). Thanks a ton!

Hi, I am assigning this to vaishnavipamulapati since they claimed it first.

Assignee: nobody → vaishnavipamulapati
Status: NEW → ASSIGNED
Blocks: dt-flexbox
Component: Inspector → Inspector: Layout
Summary: Flexbox: Distinct color for Min/Max in diagram and info chart (hoping for 65) → Flexbox: Distinct color for Min/Max in diagram and info chart

Hi vaishnavipamulapati, do you still plan on working on this bug, or should I unassign you from it so others can claim it?

Flags: needinfo?(vaishnavipamulapati)

Unassigning this bug.

Assignee: vaishnavipamulapati → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(vaishnavipamulapati)

Hi,
I would like to work on this bug :)
@Victoria, could you tell me more about dark mode please ? What is the purple equivalent ?

Thomas

Hi! You can use the purple from the dark mode syntax highlighting. It's called var(--theme-highlight-purple)

Thank you, it is great. As soon as I am assigned (if I am) I push the update for review.

Assignee: nobody → tgerard79

Yes! I just assigned it to you. Feel free to join us on Slack if you have any questions.

Docs: https://docs.firefox-dev.tools/
Slack: https://devtools-html-slack.herokuapp.com/

In the layout panel of the inspector, in the flex part, change color of min and max properties.
Change the min/max labels, and lock icon color of the flex outline box to the same color too.

Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdafcae04e43
layout flex inspector - change min/max color in diagram and info chart. r=mtigley
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.