Closed Bug 1519573 Opened 5 years ago Closed 5 years ago

Add input validation to compareChooser component

Categories

(Tree Management :: Perfherder, enhancement, P1)

Product:
Tree Management
Component:
Perfherder
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sclements, Assigned: sclements)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4452
47 bytes, text/x-github-pull-request
Details | Review

Adding improved input validation back to compareChooser, which also addresses confusing UI behavior that doesn't indicate to the user that their query params are being validated (which can take a quick second, if a revision is being validated).

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9856da2f8eb52493f9c6465c25cca1944f66df0a
Bug 1519573 - Add Perfherder compareChooser input validation (#4452)

Add improved input validation back to selectorCard component and move
query param validation to selectorCard
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: