1519589 - [Quantumbar] Middle-clicking item in dropdown should load item's url

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[custom.firefox.lady [:tawn]]

Steps to reproduce:

1. Set browser.urlbar.quantumbar to true and restart Fx to enable quantumbar.
2. Type in addressbar to cause dropdown to open.
3. Middle-click one of the suggested entries in the dropdown.

Expected result: Selected (middle-clicked) item's url opens in a new tab (same effect as Ctrl-click).

Actual result: Nothing; middle-click is ignored / not yet supported.

Comment 1

[Mark Banner (:standard8)]

Hi, thanks for the report. It does indeed seem that this isn't working at the moment, although from the code, I'd expect it to.

Note that QuantumBar isn't really ready for testing yet. It is still under heavy development and there's lots not working/not implemented yet. We'll notify people via the usual channels when it is a bit more ready for testing.

Comment 2

[Mark Banner (:standard8)]

I took a brief look via the debugger and something is preventing the click events for non-left clicks from reaching the view. Could be the input, but the debugger is not working right today, so I couldn't really work out any more detail.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1519589 - Make middle-clicking quantumbar results work by listening to mouseup instead of click events. r=Standard8

Similar to the autocomplete binding: https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/toolkit/content/widgets/autocomplete.xml#677

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19efbb6ade6a
Make middle-clicking quantumbar results work by listening to mouseup instead of click events. r=Standard8

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/19efbb6ade6a

Comment 6

[mdew]

Is there an about:config option to load the tab in the background when doing this?

Comment 7

[Dão Gottwald [:dao]]

(In reply to mdew from comment #6)

Is there an about:config option to load the tab in the background when doing this?

No, but you can hold the shift key while clicking.

Comment 8

[avada]

(In reply to Dão Gottwald [::dao] from comment #7)

(In reply to mdew from comment #6)

Is there an about:config option to load the tab in the background when doing this?

No, but you can hold the shift key while clicking.

I think this (as well as ctrl+enter) should respect the "browser. tabs. loadInBackground" setting to decide wether to open tabs in the background.