Some configure cleanup, mostly related to subconfigure

RESOLVED FIXED in Firefox 66


3 months ago
3 months ago


(Reporter: glandium, Assigned: glandium)



Firefox Tracking Flags

(firefox66 fixed)



(7 attachments)

Comment hidden (empty)

Comment 2

3 months ago
We only run it for js/src now, so get_config_files always returns empty lists.

Depends on D16378

Comment 3

3 months ago
There aren't any anymore.

Depends on D16379

Comment 4

3 months ago
Because we only ever run one subconfigure, the machinery to execute
several is not useful anymore. Inlining it allows to simplify the code
too, because it doesn't need to be generic anymore. This also removes
the last remaining bits of acwinpaths.m4.

Also remove now unused support for --list in build/

Depends on D16380

Comment 5

3 months ago
It was useful to run the prepare phase and the actual subconfigure
separately, but it's not anymore after all the recent simplications.

Depends on D16381

Comment 6

3 months ago
Because is only used for js/src and we're not going to
add any more subconfigures, we can hardcode js/src into the script, and
remove the branches that aren't taken as a consequence.

Depends on D16382

Comment 7

3 months ago
The File class is now used only in one place, only for its mtime
property, which can be replaced with os.path.getmtime.

Depends on D16402

Comment 8

3 months ago
Pushed by
Remove unused autoconf macros. r=froydnj
Remove dead code in build/ r=nalexander
Don't run subconfigure from js/src. r=nalexander
Manually inline AC_OUTPUT_SUBDIRS and MOZ_RUN_ALL_SUBCONFIGURES. r=nalexander
Run build/ in one pass. r=nalexander
Hardcode js/src into r=nalexander
Remove the File class in r=nalexander


3 months ago
Blocks: 1520340
You need to log in before you can comment on or make changes to this bug.