1519603 - Some configure cleanup, mostly related to subconfigure

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1519603 - Remove unused autoconf macros.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1519603 - Remove dead code in build/subconfigure.py.

We only run it for js/src now, so get_config_files always returns empty lists.

Depends on D16378

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1519603 - Don't run subconfigure from js/src.

There aren't any anymore.

Depends on D16379

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1519603 - Manually inline AC_OUTPUT_SUBDIRS and MOZ_RUN_ALL_SUBCONFIGURES.

Because we only ever run one subconfigure, the machinery to execute
several is not useful anymore. Inlining it allows to simplify the code
too, because it doesn't need to be generic anymore. This also removes
the last remaining bits of acwinpaths.m4.

Also remove now unused support for --list in build/subconfigure.py.

Depends on D16380

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1519603 - Run build/subconfigure.py in one pass.

It was useful to run the prepare phase and the actual subconfigure
separately, but it's not anymore after all the recent simplications.

Depends on D16381

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1519603 - Hardcode js/src into subconfigure.py.

Because subconfigure.py is only used for js/src and we're not going to
add any more subconfigures, we can hardcode js/src into the script, and
remove the branches that aren't taken as a consequence.

Depends on D16382

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1519603 - Remove the File class in subconfigure.py.

The File class is now used only in one place, only for its mtime
property, which can be replaced with os.path.getmtime.

Depends on D16402

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9386709aeec0
Remove unused autoconf macros. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/c8f92004fdfb
Remove dead code in build/subconfigure.py. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/78ac28070bad
Don't run subconfigure from js/src. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/129e9f6b6295
Manually inline AC_OUTPUT_SUBDIRS and MOZ_RUN_ALL_SUBCONFIGURES. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/8688b128061b
Run build/subconfigure.py in one pass. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/94f3932b2f95
Hardcode js/src into subconfigure.py. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/2809c756574d
Remove the File class in subconfigure.py. r=nalexander

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9386709aeec0
https://hg.mozilla.org/mozilla-central/rev/c8f92004fdfb
https://hg.mozilla.org/mozilla-central/rev/78ac28070bad
https://hg.mozilla.org/mozilla-central/rev/129e9f6b6295
https://hg.mozilla.org/mozilla-central/rev/8688b128061b
https://hg.mozilla.org/mozilla-central/rev/94f3932b2f95
https://hg.mozilla.org/mozilla-central/rev/2809c756574d