Some configure cleanup, mostly related to subconfigure

RESOLVED FIXED in Firefox 66

Status

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla66

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(7 attachments)

Comment hidden (empty)
(Assignee)

Comment 2

3 months ago
We only run it for js/src now, so get_config_files always returns empty lists.

Depends on D16378
(Assignee)

Comment 3

3 months ago
There aren't any anymore.

Depends on D16379
(Assignee)

Comment 4

3 months ago
Because we only ever run one subconfigure, the machinery to execute
several is not useful anymore. Inlining it allows to simplify the code
too, because it doesn't need to be generic anymore. This also removes
the last remaining bits of acwinpaths.m4.

Also remove now unused support for --list in build/subconfigure.py.

Depends on D16380
(Assignee)

Comment 5

3 months ago
It was useful to run the prepare phase and the actual subconfigure
separately, but it's not anymore after all the recent simplications.

Depends on D16381
(Assignee)

Comment 6

3 months ago
Because subconfigure.py is only used for js/src and we're not going to
add any more subconfigures, we can hardcode js/src into the script, and
remove the branches that aren't taken as a consequence.

Depends on D16382
(Assignee)

Comment 7

3 months ago
The File class is now used only in one place, only for its mtime
property, which can be replaced with os.path.getmtime.

Depends on D16402

Comment 8

3 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/9386709aeec0
Remove unused autoconf macros. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/c8f92004fdfb
Remove dead code in build/subconfigure.py. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/78ac28070bad
Don't run subconfigure from js/src. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/129e9f6b6295
Manually inline AC_OUTPUT_SUBDIRS and MOZ_RUN_ALL_SUBCONFIGURES. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/8688b128061b
Run build/subconfigure.py in one pass. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/94f3932b2f95
Hardcode js/src into subconfigure.py. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/2809c756574d
Remove the File class in subconfigure.py. r=nalexander
(Assignee)

Updated

3 months ago
Blocks: 1520340
You need to log in before you can comment on or make changes to this bug.