1519626 - test_ext_permission_warnings.js fails when run in Thunderbird

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1504018 +++

The problem is that the test uses
const bundle = Services.strings.createBundle("chrome://browser/locale/browser.properties");

and that bundle is not available. I little unfortunate that browser has crept into toolkit here.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1519626-test_ext_permission_warnings.patch

Andrew, feel free to r- and suggest a better solution.

Comment 2

[Rob Wu [:robwu]]

Can you update the test code to import the following if the app is Thunderbird:

Services.strings.createBundle("chrome://messenger/locale/addons.properties");

The test relies on the following:
https://searchfox.org/comm-central/rev/ab062df16f6764dfe7adad09a21fc84a4af732d0/mail/locales/en-US/chrome/messenger/addons.properties#151-203

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1519626-test_ext_permission_warnings-take-2.patch

Thanks for the tip!

Comment 4

[Rob Wu [:robwu]]

Comment on attachment 9036117 [details] [diff] [review]
1519626-test_ext_permission_warnings-take-2.patch

Review of attachment 9036117 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/test/xpcshell/test_ext_permission_warnings.js
@@ +1,4 @@
>  "use strict";
>  
>  let {ExtensionTestCommon} = ChromeUtils.import("resource://testing-common/ExtensionTestCommon.jsm", {});
> +let {AppConstants} = ChromeUtils.import("resource://gre/modules/AppConstants.jsm", {});

Remove this line.
AppConstants is already imported via toolkit/components/extensions/test/xpcshell/head.js

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1519626-test_ext_permission_warnings-take-2.patch (v1b) - please change to r=robwu,aswan

Comment 6

[Rob Wu [:robwu]]

Comment on attachment 9036123 [details] [diff] [review]
1519626-test_ext_permission_warnings-take-2.patch (v1b) - please change to r=robwu,aswan

Review of attachment 9036123 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I'm not a peer, so let's also ask aswan for r+.

Comment 7

[Intermittent Failures Robot]

15 failures in 2627 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 15

Platform breakdown:

• linux32: 2
• windows10-64: 2
• windows7-32-nightly: 1
• macosx64-nightly: 1
• linux32-nightly: 1
• windows10-64-nightly: 1
• linux64-nightly: 1
• osx-10-10: 2
• windows7-32: 2
• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519626&startday=2019-01-07&endday=2019-01-13&tree=all

Comment 8

[Andrew Swan [:aswan]]

Comment on attachment 9036123 [details] [diff] [review]
1519626-test_ext_permission_warnings-take-2.patch (v1b) - please change to r=robwu,aswan

Review of attachment 9036123 [details] [diff] [review]:
-----------------------------------------------------------------

I guess even better would be creating a test-specific string bundle for the purpose of this test to break the dependency on non-toolkit assets, but this seems fine for now.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd4be420c44f
Use application specific string bundle in test_ext_permission_warnings.js. r=robwu,aswan

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fd4be420c44f

Comment 11

[Vlad Jiman]

Will this fix require manual validation? if yes please specify how exactly to correctly validate it, thanks!

Comment 12

[Jorg K (CEST = GMT+2)]

Nothing to verify here, thanks for asking. The test now passes for Firefox and Thunderbird.

Comment 13

[Intermittent Failures Robot]

11 failures in 2378 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 11

Platform breakdown:

• windows10-64: 2
• linux32: 2
• osx-10-10: 3
• linux64: 2
• windows7-32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519626&startday=2019-01-14&endday=2019-01-20&tree=all