Stylo fails with --enable-warnings-as-errors using Rust 1.33

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
6 months ago
15 days ago

People

(Reporter: jbeich, Assigned: emilio)

Tracking

60 Branch
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 unaffected, firefox66 fixed)

Details

After bug 1513009 and https://github.com/rust-lang/rust/pull/56407 build fails.

$ rustc -vV
rustc 1.33.0-nightly
binary: rustc
commit-hash: 6ecad338381c
commit-date: 2019-01-09
host: x86_64-unknown-freebsd
release: 1.33.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors # mimic MOZ_AUTOMATION" >>.mozconfig
$ ./mach build
[...]
error: missing documentation for macro
--> servo/components/style_traits/values.rs:162:1
|
162 | macro_rules! serialize_function {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: lint level defined here
--> servo/components/style_traits/lib.rs:11:22
|
11 | #![deny(unsafe_code, missing_docs)]
| ^^^^^^^^^^^^

error: missing documentation for macro
--> servo/components/style_traits/values.rs:454:1
|
454 | macro_rules! define_css_keyword_enum {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors
error: Could not compile style_traits.

Fixed already in https://github.com/servo/servo/pull/22674, need to cherry-pick that. Will do the next sync as soon as I have a decent internet connection :)

That fix wasn't enough:

error: missing documentation for macro
--> objdir/x86_64-unknown-freebsd/release/build/style-4911552580805987/out/gecko/atom_macro.rs:9:1
|
9 | macro_rules! atom {
| ^^^^^^^^^^^^^^^^^
|
note: lint level defined here
--> servo/components/style/lib.rs:26:9
|
26| #![deny(missing_docs)]
| ^^^^^^^^^^^^

error: missing documentation for macro
--> servo/components/style/gecko_string_cache/namespace.rs:15:1
|
15 | macro_rules! ns {
| ^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors
error: Could not compile style.

Depends on: 1519729
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → emilio
You need to log in before you can comment on or make changes to this bug.