Open Bug 1519636 Opened 1 year ago Updated 3 days ago

Reformat recent changes to the Google coding style

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set

Tracking

(Not tracked)

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(33 files, 3 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
3.54 KB, patch
Details | Diff | Splinter Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1512961 +++

Until we have the tooling, I propose that we use this bug with the leave-open keyword to avoid creating one bug per update.

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d54846d01280
Reformat everything to the Google coding style r=Ehsan
Depends on: 1521307
Attachment #9037770 - Attachment is obsolete: true
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d536f45f5b16
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2307fb1cfa80
Ride along: remove unbreakable spaces r=Ehsan
Attachment #9038038 - Attachment is obsolete: true

ignore-this-changeset

Depends on D17388

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08b686c04a01
Reformat recent changes to the Google coding style r=Ehsan
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07f6f62a24f5
Follow-up to properly turn off clang formatting for debug logging code. r=me
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3924aed041cf
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a031c9dd9dd5
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa3daa92292d
Ride along: Add media/libdav1d/version.h to the ignore list r=andi
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7de6e431f1ae
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/389b6bbd76db
clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ad80127f89f
clang-format-8: Reformat recent changes to the Google coding style r=Ehsan

Backed out for bustage on MarkupMap.h and nsAccessibilityService.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/6d386a2162b90d72529adbc283391fc4732eff32

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4ad80127f89f58dd562fba3e8cececb66b29e62f&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238331063&repo=autoland&lineNumber=23498

[task 2019-04-05T06:40:30.958Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/accessible/base/Unified_cpp_accessible_base1.cpp:56:
[task 2019-04-05T06:40:30.959Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/accessible/base/nsAccessibilityService.cpp:217:
[task 2019-04-05T06:40:30.960Z] 06:40:30 ERROR - /builds/worker/workspace/build/src/accessible/base/MarkupMap.h:21:17: error: expected expression
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - roles::LINK);
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/accessible/base/Unified_cpp_accessible_base1.cpp:56:
[task 2019-04-05T06:40:30.961Z] 06:40:30 ERROR - /builds/worker/workspace/build/src/accessible/base/nsAccessibilityService.cpp:255:22: error: no matching function for call to 'ArrayLength'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList))
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^~~~~~~~~~~
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:54:18: note: candidate template ignored: could not match 'T [N]' against 'const mozilla::a11y::HTMLMarkupMapInfo []'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - constexpr size_t ArrayLength(T (&aArr)[N]) {
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:59:18: note: candidate template ignored: could not match 'Array<type-parameter-0-0, Length>' against 'mozilla::a11y::HTMLMarkupMapInfo const[]'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - constexpr size_t ArrayLength(const Array<T, N>& aArr) {
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:64:18: note: candidate template ignored: could not match 'EnumeratedArray<type-parameter-0-0, SizeAsEnumValue, type-parameter-0-2>' against 'mozilla::a11y::HTMLMarkupMapInfo const[]'
[task 2019-04-05T06:40:30.962Z] 06:40:30 INFO - constexpr size_t ArrayLength(const EnumeratedArray<E, N, T>& aArr) {
[task 2019-04-05T06:40:30.962Z] 06:40:30 INFO -

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/662b776a02e6
clang-format-8: Reformat recent changes to the Google coding style r=Ehsan

should be good this time :)

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f95dc32944ac
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44928a7f5745
Reformat recent changes to the Google coding style r=Ehsan

ignore-this-changeset

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d091a005f031
Reformat recent changes to the Google coding style r=Ehsan

Hi, can you please tell me what # ignore-this-changeset in the header does? I thought it might suppress blame, but not so, see for example:
https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/accessible/generic/HyperTextAccessible.cpp#1851

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/e04d7e4e58a1
No Bug - Ignore Bug 1519636 in blame/annotate. r=sylvestre
Attachment #9060904 - Attachment is obsolete: true

(In reply to Jorg K (GMT+2) from comment #60)

Hi, can you please tell me what # ignore-this-changeset in the header does? I thought it might suppress blame, but not so, see for example:
https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/accessible/generic/HyperTextAccessible.cpp#1851

Please see https://lists.mozilla.org/pipermail/dev-platform/2019-January/023284.html.

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a296439a25ff
Reformat recent changes to the Google coding style r=Ehsan

The error is

11:16:26  WARNING -  TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook ApiSetQueryApiSetPresence from Api - ms - win - core - apiquery - l1 - 1 - 0.dll
11:16:26  WARNING -  TEST-UNEXPECTED-FAIL | TestDllInterceptor.exe | test failed with return code 1

caused by this diff:

   TEST_DETOUR_SKIP_EXEC(kernel32.dll, BaseThreadInitThunk) &&
   TEST_DETOUR_SKIP_EXEC(ntdll.dll, LdrLoadDll) &&
  •  MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(), Api-ms-win-core-apiquery-l1-1-0.dll, ApiSetQueryApiSetPresence, Equals, FALSE, &gEmptyUnicodeString, &gIsPresent) &&
    
  •  MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(),
    
  •                         Api - ms - win - core - apiquery - l1 - 1 - 0.dll,
    
  •                         ApiSetQueryApiSetPresence, Equals, FALSE,
    
  •                         &gEmptyUnicodeString, &gIsPresent) &&
    
Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edbf8267dd4f
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dbf929c30ae
Reformat recent changes to the Google coding style r=Ehsan
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98eb0b753429
Mark the entire media/libdav1d directory as third-party; r=andi

I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).

(In reply to Mike Hommey [:glandium] from comment #78)

I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).

Thanks. Do you mind filing bugs for these in the future please? :-)

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50b6e4480ea0
Reformat recent changes to the Google coding style r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/3dc9d0ab9eea
Ride along - remove useless ';' r=andi
Depends on: 1563903

(In reply to Mike Hommey [:glandium] from comment #78)

I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).
Created bug 1563903 for this!

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0edb7e828465
Reformat recent changes to the Google coding style r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/bce47e0ee177
Ride along: remove trailing whitespaces r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/0a036b8258bf
Ride along: Move to the unix CR type r=Ehsan
Attached patch a.diffSplinter Review
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81c861509782
Fix some conflicts r=bustage . CLOSED TREE
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53bd948e892d
Reformat recent changes to the Google coding style r=Ehsan

ignore-this-changeset

Depends on D47736

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e245551f316b
Add some lint tests in the clang-format ignore list r=andi
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7214f827b7fb
Reformat recent changes to the Google coding style r=Ehsan

Please note that it is the first reformat with clang-format 9
I only saw a fix in the .mm file

ignore-this-changeset

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e50facddb3c9
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e9c25f6c1ec
Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ca91a6eaf8d
Reformat recent changes to the Google coding style r=Ehsan
Attachment #9121706 - Attachment description: Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan,sg → Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan,sg
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b990267ff717
Automatically reformat recent changes using clang-format r=Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06762c633bf6
Reformat recent changes to the Google coding style r=Ehsan,kvark
You need to log in before you can comment on or make changes to this bug.