Open Bug 1519636 Opened 6 years ago Updated 5 months ago

Reformat recent changes to the Google coding style

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

enhancement

Tracking

(Not tracked)

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

(Keywords: leave-open)

Attachments

(79 files, 19 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
3.54 KB, patch
Details | Diff | Splinter Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1512961 +++

Until we have the tooling, I propose that we use this bug with the leave-open keyword to avoid creating one bug per update.

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d54846d01280 Reformat everything to the Google coding style r=Ehsan
Depends on: 1521307
Attachment #9037770 - Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d536f45f5b16 Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2307fb1cfa80 Ride along: remove unbreakable spaces r=Ehsan
Attachment #9038038 - Attachment is obsolete: true

ignore-this-changeset

Depends on D17388

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08b686c04a01 Reformat recent changes to the Google coding style r=Ehsan
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07f6f62a24f5 Follow-up to properly turn off clang formatting for debug logging code. r=me
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3924aed041cf Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a031c9dd9dd5 Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa3daa92292d Ride along: Add media/libdav1d/version.h to the ignore list r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7de6e431f1ae Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/389b6bbd76db clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ad80127f89f clang-format-8: Reformat recent changes to the Google coding style r=Ehsan

Backed out for bustage on MarkupMap.h and nsAccessibilityService.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/6d386a2162b90d72529adbc283391fc4732eff32

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4ad80127f89f58dd562fba3e8cececb66b29e62f&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238331063&repo=autoland&lineNumber=23498

[task 2019-04-05T06:40:30.958Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/accessible/base/Unified_cpp_accessible_base1.cpp:56:
[task 2019-04-05T06:40:30.959Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/accessible/base/nsAccessibilityService.cpp:217:
[task 2019-04-05T06:40:30.960Z] 06:40:30 ERROR - /builds/worker/workspace/build/src/accessible/base/MarkupMap.h:21:17: error: expected expression
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - roles::LINK);
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/accessible/base/Unified_cpp_accessible_base1.cpp:56:
[task 2019-04-05T06:40:30.961Z] 06:40:30 ERROR - /builds/worker/workspace/build/src/accessible/base/nsAccessibilityService.cpp:255:22: error: no matching function for call to 'ArrayLength'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList))
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^~~~~~~~~~~
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:54:18: note: candidate template ignored: could not match 'T [N]' against 'const mozilla::a11y::HTMLMarkupMapInfo []'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - constexpr size_t ArrayLength(T (&aArr)[N]) {
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:59:18: note: candidate template ignored: could not match 'Array<type-parameter-0-0, Length>' against 'mozilla::a11y::HTMLMarkupMapInfo const[]'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - constexpr size_t ArrayLength(const Array<T, N>& aArr) {
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:64:18: note: candidate template ignored: could not match 'EnumeratedArray<type-parameter-0-0, SizeAsEnumValue, type-parameter-0-2>' against 'mozilla::a11y::HTMLMarkupMapInfo const[]'
[task 2019-04-05T06:40:30.962Z] 06:40:30 INFO - constexpr size_t ArrayLength(const EnumeratedArray<E, N, T>& aArr) {
[task 2019-04-05T06:40:30.962Z] 06:40:30 INFO -

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/662b776a02e6 clang-format-8: Reformat recent changes to the Google coding style r=Ehsan

should be good this time :)

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f95dc32944ac Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/44928a7f5745 Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d091a005f031 Reformat recent changes to the Google coding style r=Ehsan

Hi, can you please tell me what # ignore-this-changeset in the header does? I thought it might suppress blame, but not so, see for example:
https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/accessible/generic/HyperTextAccessible.cpp#1851

Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/e04d7e4e58a1 No Bug - Ignore Bug 1519636 in blame/annotate. r=sylvestre
Attachment #9060904 - Attachment is obsolete: true

(In reply to Jorg K (GMT+2) from comment #60)

Hi, can you please tell me what # ignore-this-changeset in the header does? I thought it might suppress blame, but not so, see for example:
https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/accessible/generic/HyperTextAccessible.cpp#1851

Please see https://lists.mozilla.org/pipermail/dev-platform/2019-January/023284.html.

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a296439a25ff Reformat recent changes to the Google coding style r=Ehsan

The error is

11:16:26  WARNING -  TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook ApiSetQueryApiSetPresence from Api - ms - win - core - apiquery - l1 - 1 - 0.dll
11:16:26  WARNING -  TEST-UNEXPECTED-FAIL | TestDllInterceptor.exe | test failed with return code 1

caused by this diff:

   TEST_DETOUR_SKIP_EXEC(kernel32.dll, BaseThreadInitThunk) &&
   TEST_DETOUR_SKIP_EXEC(ntdll.dll, LdrLoadDll) &&
  •  MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(), Api-ms-win-core-apiquery-l1-1-0.dll, ApiSetQueryApiSetPresence, Equals, FALSE, &gEmptyUnicodeString, &gIsPresent) &&
    
  •  MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(),
    
  •                         Api - ms - win - core - apiquery - l1 - 1 - 0.dll,
    
  •                         ApiSetQueryApiSetPresence, Equals, FALSE,
    
  •                         &gEmptyUnicodeString, &gIsPresent) &&
    
Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edbf8267dd4f Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1dbf929c30ae Reformat recent changes to the Google coding style r=Ehsan
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/98eb0b753429 Mark the entire media/libdav1d directory as third-party; r=andi

I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).

(In reply to Mike Hommey [:glandium] from comment #78)

I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).

Thanks. Do you mind filing bugs for these in the future please? :-)

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50b6e4480ea0 Reformat recent changes to the Google coding style r=Ehsan https://hg.mozilla.org/integration/autoland/rev/3dc9d0ab9eea Ride along - remove useless ';' r=andi
Depends on: 1563903

(In reply to Mike Hommey [:glandium] from comment #78)

I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).
Created bug 1563903 for this!

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0edb7e828465 Reformat recent changes to the Google coding style r=Ehsan https://hg.mozilla.org/integration/autoland/rev/bce47e0ee177 Ride along: remove trailing whitespaces r=Ehsan https://hg.mozilla.org/integration/autoland/rev/0a036b8258bf Ride along: Move to the unix CR type r=Ehsan
Attached patch a.diffSplinter Review
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81c861509782 Fix some conflicts r=bustage . CLOSED TREE
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53bd948e892d Reformat recent changes to the Google coding style r=Ehsan

ignore-this-changeset

Depends on D47736

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e245551f316b Add some lint tests in the clang-format ignore list r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7214f827b7fb Reformat recent changes to the Google coding style r=Ehsan

Please note that it is the first reformat with clang-format 9
I only saw a fix in the .mm file

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e50facddb3c9 Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e9c25f6c1ec Reformat recent changes to the Google coding style r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ca91a6eaf8d Reformat recent changes to the Google coding style r=Ehsan
Attachment #9121706 - Attachment description: Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan,sg → Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan,sg
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b990267ff717 Automatically reformat recent changes using clang-format r=Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06762c633bf6 Reformat recent changes to the Google coding style r=Ehsan,kvark
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65fc57fa542c Reformat recent changes to the Google coding style r=jgilbert
Regressions: 1627580
No longer regressions: 1627580
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c369973911e Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c009b34d58a2 Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b0a2fb2193f follow up - Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a5d011e7468 Reformat recent changes to the Google coding style r=necko-reviewers,dragana

ignore-this-changeset

Depends on D79153

Attachment #9156918 - Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7db13cef3939 Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c209abd2eac7 Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e619e7dc301 Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20019504d440 Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0f173a90792 Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b459c30cad3f Reformat recent changes to the Google coding style r=andi

I mixed two commits, this is fixed now. Sorry!

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2a6ca456ddc Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a903337b1be9 Reformat recent changes to the Google coding style r=andi
Attachment #9179642 - Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf1fbc9e403c Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2977d4891cee Reformat recent changes to the Google coding style r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6aa4d3de0728 Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana

It is bringing some minor changes

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c07e6f1f530 Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34a6f0add455 Reformat recent changes to the Google coding style r=andi

Updated with clang-format version 11.0.0

ignore-this-changeset

Updated with Debian clang-format version 11.0.1-1

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/371c029d8743 Reformat recent changes to the Google coding style r=andi
Attachment #9194189 - Attachment is obsolete: true

Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9544dd3a91ef Reformat recent changes to the Google coding style r=andi

Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)

ignore-this-changeset

Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/38345c699f68 Reformat recent changes to the Google coding style r=andi,necko-reviewers

Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/109b53d16a71 Reformat recent changes to the Google coding style r=necko-reviewers,valentin

Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)

# ignore-this-changeset

Updated with Debian clang-format version 12.0.0-++rc3-1~exp1

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9797872fe7aa Reformat recent changes to the Google coding style r=andi

Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)

# ignore-this-changeset

Attachment #9218258 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8f02e3a863d Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi

Updated with clang-format version 12.0.0 (taskcluster-J6SC83dpSwKvi0nTd5WuMg)

Attachment #9208980 - Attachment is obsolete: true
Attachment #9220051 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.

Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)

Attachment #9220051 - Attachment description: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Init reformat of C/C++ code with clang-format version 12.0.0.
Attachment #9220051 - Attachment description: Bug 1519636 - Init reformat of C/C++ code with clang-format version 12.0.0. → Bug 1519636 - Initial reformat of C/C++ code with clang-format version 12.0.0. r=sylvestre
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dbe9bfce447 Reformat recent changes to the Google coding style. r=necko-reviewers,valentin,sylvestre https://hg.mozilla.org/integration/autoland/rev/fc1023cb15a3 Initial reformat of C/C++ code with clang-format version 12.0.0. r=sylvestre

Updated with clang-format version 12.0.0 (taskcluster-KEgO7qdgQ8uaewA6NkRnRA)

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d19e1260d34d Reformat recent changes to the Google coding style. r=emilio

Updated with clang-format version 12.0.0 (taskcluster-FZRqPXamQIOU_i4hF0cAcg)

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0eecc59f9ee Reformat recent changes to the Google coding style. r=necko-reviewers,emilio

Updated with clang-format version 12.0.1 (taskcluster-dNZqCRqWRTqa6cZxPKxh7Q)

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48f5a6cd1340 Reformat recent changes to the Google coding style. r=emilio

Updated with clang-format version 13.0.0 (taskcluster-VobPDBQ8RSWourYFs_U38w)

Attachment #9247011 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.

Reformat with clang-format version 12.0.1 (taskcluster-FYV2l5wGTseBAhiqf8cxfQ)

Attachment #9247011 - Attachment description: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - First reformat with clang-format 13.0.0.
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d88d0a8e1d38 Reformat recent changes to the Google coding style. r=firefox-build-system-reviewers,mhentges,sylvestre https://hg.mozilla.org/integration/autoland/rev/704f09a557a4 First reformat with clang-format 13.0.0. r=firefox-build-system-reviewers,sylvestre,mhentges

Updated with clang-format version 13.0.0 (taskcluster-cMIjs2JaRe6fqM2zK7ZACQ)

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5a71bd269a0 Reformat recent changes to the Google coding style. r=sylvestre

Updated with clang-format version 13.0.0 (taskcluster-dn0nWlPhT22vaQNfMnFkSg)

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c08caa5f8504 Reformat recent changes to the Google coding style. r=sylvestre

Backed out for causing lint failures on multiple files

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
  • Failure line 2: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:1 | Empty Lines at end of file (file-whitespace)
Flags: needinfo?(sledru)
Flags: needinfo?(sledru) → needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/adb37cc98185 Reformat recent changes to the Google coding style. r=sylvestre

Updated with clang-format version 13.0.0 (taskcluster-dIIauZE0TkuXy6_23BQhcw)

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfda402b1582 Reformat recent changes to the Google coding style. r=sylvestre

First reformat with clang-format version 13.0.1 (taskcluster-MgYYdzd4SM6nz43RqVFoxw)

ignore-this-changeset

Updated with clang-format version 13.0.1 (taskcluster-eMexrV3KSgudp2OvUPA6hw)

ignore-this-changeset

Attachment #9270641 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.
Flags: needinfo?(bpostelnicu)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5c3a162f850 Reformat recent changes to the Google coding style r=andi,media-playback-reviewers,necko-reviewers,padenot,dragana

Updated with clang-format version 13.0.1 (taskcluster-eMexrV3KSgudp2OvUPA6hw)

ignore-this-changeset

Attachment #9282528 - Attachment is obsolete: true

Updated with clang-format version 14.0.5 (taskcluster-YlgDNB2QSm-6a2LDw3kj6A)

ignore-this-changeset

Attachment #9282530 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bc2b595a253 Reformat recent changes to the Google coding style. r=marco
Attachment #9262815 - Attachment is obsolete: true

Updated with clang-format version 14.0.5 (taskcluster-cAkeFEZXQmihHYDO8Y4hRw)

ignore-this-changeset

Attachment #9284107 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.
Attachment #9284107 - Attachment description: Bug 1519636 - Reformat recent changes to the Google coding style. → WIP: Bug 1519636 - Reformat recent changes to the Google coding style.
Attachment #9270641 - Attachment is obsolete: true
Attachment #9284107 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36b6cd1e3894 Reformat recent changes to the Google coding style. r=media-playback-reviewers,alwu

Updated with clang-format version 14.0.5 (taskcluster-ThuAJINyTKOILKeakawQZw)

ignore-this-changeset

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edc6e12812c1 Reformat recent changes to the Google coding style. r=marco

Updated with clang-format version 14.0.5 (taskcluster-DydCt-ryTuKvBYw1HQOugw)

ignore-this-changeset

Attachment #9289893 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28d5b86884fe Reformat recent changes to the Google coding style. r=glandium
Product: Firefox Build System → Developer Infrastructure
Severity: normal → S3

Updated with clang-format version 15.0.5 (taskcluster-DZwDzAEyTfOc6FxuNVvlFQ)

ignore-this-changeset

Updated with clang-format version 15.0.5 (taskcluster-MKK8dHUpQkGfPLA793lizg)

ignore-this-changeset

Attachment #9304859 - Attachment is obsolete: true
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebc57d2ea277 Reformat recent changes to the Google coding style. r=glandium

Updated with clang-format version 16.0.2 (taskcluster-f_cdG-1bSlu58g2TVuOBIQ)

ignore-this-changeset

Updated with clang-format version 16.0.4 (taskcluster-BdnDno4LRs6FtMqXEhTRmQ)

ignore-this-changeset

Attachment #9337704 - Attachment description: WIP: Bug 1519636 - Reformat recent changes to the Google coding style. → Bug 1519636 - Reformat recent changes to the Google coding style.
Attachment #9331187 - Attachment is obsolete: true
Attachment #9337704 - Attachment is obsolete: true

Updated with clang-format version 16.0.6 (taskcluster-MKoiQC5YTyWVz1BTt5NOVA)

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8ef574257c7 Remove nbsp in the doc r=firefox-source-docs-reviewers,geckoview-reviewers,ahal,m_kato

clang-format version 17.0.6 (taskcluster-QueHFUviQeyM8Y7r_d7MQQ)

ignore-this-changeset

Depends on D195370

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e06c8b755cc3 Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47051dc89633 Remove nbsp in the perfdoc doc r=perftest-reviewers,aglavic,jmaher
Attachment #9396860 - Attachment is obsolete: true
Attachment #9396861 - Attachment is obsolete: true
Attachment #9396865 - Attachment is obsolete: true

ignore-this-changeset

Depends on D207866

Attachment #9396883 - Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/057fc4be20f8 add intl/icu_capi/ and dom/media/platforms/ffmpeg/ to the clang ignore list r=emilio https://hg.mozilla.org/integration/autoland/rev/381e8eeb997c Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot
Attachment #9411530 - Attachment is obsolete: true
Attachment #9411532 - Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dffee1bbc064 Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: