Reformat recent changes to the Google coding style
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(Not tracked)
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
(Keywords: leave-open)
Attachments
(76 files, 13 obsolete files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
3.54 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1512961 +++
Assignee | ||
Comment 1•5 years ago
|
||
Until we have the tooling, I propose that we use this bug with the leave-open keyword to avoid creating one bug per update.
Assignee | ||
Comment 2•5 years ago
|
||
# ignore-this-changeset
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d54846d01280 Reformat everything to the Google coding style r=Ehsan
Comment 4•5 years ago
|
||
bugherder |
Assignee | ||
Comment 5•5 years ago
|
||
ignore-this-changeset
Assignee | ||
Comment 6•5 years ago
|
||
Depends on D17063
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D17064
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D17065
Updated•5 years ago
|
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d536f45f5b16 Reformat recent changes to the Google coding style r=Ehsan
Comment 10•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2307fb1cfa80 Ride along: remove unbreakable spaces r=Ehsan
Comment 11•5 years ago
|
||
bugherder |
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d46c1872ba7920465cdf33b52672a374a66e360 Bug 1519636 - Ride along: Add more commits to the git ignore list r=ehsan
Updated•5 years ago
|
Comment 14•5 years ago
|
||
bugherder |
Comment 15•5 years ago
|
||
bugherder |
Assignee | ||
Comment 16•5 years ago
|
||
ignore-this-changeset
Depends on D17388
Comment 17•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08b686c04a01 Reformat recent changes to the Google coding style r=Ehsan
Comment 18•5 years ago
|
||
bugherder |
Comment 19•5 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07f6f62a24f5 Follow-up to properly turn off clang formatting for debug logging code. r=me
Comment 20•5 years ago
|
||
bugherder |
Assignee | ||
Comment 21•5 years ago
|
||
ignore-this-changeset
Comment 22•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3924aed041cf Reformat recent changes to the Google coding style r=Ehsan
Comment 23•5 years ago
|
||
bugherder |
Assignee | ||
Comment 24•5 years ago
|
||
ignore-this-changeset
Comment 25•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a031c9dd9dd5 Reformat recent changes to the Google coding style r=Ehsan
Comment 26•5 years ago
|
||
bugherder |
Assignee | ||
Comment 27•5 years ago
|
||
ignore-this-changeset
Assignee | ||
Comment 28•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9adeff2c423fc4ac047b4ddbdbb9b8e64ce7fdac Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
Comment 29•5 years ago
|
||
bugherder |
Assignee | ||
Comment 30•5 years ago
|
||
ignore-this-changeset
Assignee | ||
Comment 31•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d55401632cea92b6b2775ba278274b5490275876 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
Comment 32•5 years ago
|
||
bugherder |
Assignee | ||
Comment 33•5 years ago
|
||
ignore-this-changeset
Assignee | ||
Comment 34•5 years ago
|
||
Comment 35•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa3daa92292d Ride along: Add media/libdav1d/version.h to the ignore list r=andi
Comment 36•5 years ago
|
||
bugherder |
Comment 37•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7de6e431f1ae Reformat recent changes to the Google coding style r=Ehsan
Comment 38•5 years ago
|
||
bugherder |
Assignee | ||
Comment 39•5 years ago
|
||
ignore-this-changeset
Comment 40•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/389b6bbd76db clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
Comment 41•5 years ago
|
||
Backed out for bustages on MarkupMap.h
Backout link: https://hg.mozilla.org/integration/autoland/rev/9e48fefcf1aca74fd97036121180907de52756e8
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238258556&repo=autoland&lineNumber=22115
Comment 42•5 years ago
|
||
There are also bustages on ArrayUtils.h
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238258547&repo=autoland&lineNumber=27690
Assignee | ||
Comment 43•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a5a85177005e3f67c94634998dd0df5f0ce5115
Comment 44•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ad80127f89f clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
Comment 45•5 years ago
|
||
Backed out for bustage on MarkupMap.h and nsAccessibilityService.cpp
backout: https://hg.mozilla.org/integration/autoland/rev/6d386a2162b90d72529adbc283391fc4732eff32
failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238331063&repo=autoland&lineNumber=23498
[task 2019-04-05T06:40:30.958Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/accessible/base/Unified_cpp_accessible_base1.cpp:56:
[task 2019-04-05T06:40:30.959Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/accessible/base/nsAccessibilityService.cpp:217:
[task 2019-04-05T06:40:30.960Z] 06:40:30 ERROR - /builds/worker/workspace/build/src/accessible/base/MarkupMap.h:21:17: error: expected expression
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - roles::LINK);
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.960Z] 06:40:30 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/accessible/base/Unified_cpp_accessible_base1.cpp:56:
[task 2019-04-05T06:40:30.961Z] 06:40:30 ERROR - /builds/worker/workspace/build/src/accessible/base/nsAccessibilityService.cpp:255:22: error: no matching function for call to 'ArrayLength'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList))
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^~~~~~~~~~~
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:54:18: note: candidate template ignored: could not match 'T [N]' against 'const mozilla::a11y::HTMLMarkupMapInfo []'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - constexpr size_t ArrayLength(T (&aArr)[N]) {
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:59:18: note: candidate template ignored: could not match 'Array<type-parameter-0-0, Length>' against 'mozilla::a11y::HTMLMarkupMapInfo const[]'
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - constexpr size_t ArrayLength(const Array<T, N>& aArr) {
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - ^
[task 2019-04-05T06:40:30.961Z] 06:40:30 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ArrayUtils.h:64:18: note: candidate template ignored: could not match 'EnumeratedArray<type-parameter-0-0, SizeAsEnumValue, type-parameter-0-2>' against 'mozilla::a11y::HTMLMarkupMapInfo const[]'
[task 2019-04-05T06:40:30.962Z] 06:40:30 INFO - constexpr size_t ArrayLength(const EnumeratedArray<E, N, T>& aArr) {
[task 2019-04-05T06:40:30.962Z] 06:40:30 INFO -
Comment 46•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/662b776a02e6 clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
Comment 48•5 years ago
|
||
bugherder |
Comment hidden (obsolete) |
Assignee | ||
Comment 50•5 years ago
|
||
ignore-this-changeset
Comment 51•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f95dc32944ac Reformat recent changes to the Google coding style r=Ehsan
Comment 52•5 years ago
|
||
bugherder |
Assignee | ||
Comment 53•5 years ago
|
||
ignore-this-changeset
Comment 54•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/44928a7f5745 Reformat recent changes to the Google coding style r=Ehsan
Comment 55•5 years ago
|
||
bugherder |
Assignee | ||
Comment 56•5 years ago
|
||
ignore-this-changeset
Assignee | ||
Comment 57•5 years ago
|
||
ignore-this-changeset
Comment 58•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d091a005f031 Reformat recent changes to the Google coding style r=Ehsan
Comment 59•5 years ago
|
||
bugherder |
Comment 60•5 years ago
|
||
Hi, can you please tell me what # ignore-this-changeset
in the header does? I thought it might suppress blame, but not so, see for example:
https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/accessible/generic/HyperTextAccessible.cpp#1851
Comment 61•5 years ago
|
||
Comment 62•5 years ago
|
||
Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/e04d7e4e58a1 No Bug - Ignore Bug 1519636 in blame/annotate. r=sylvestre
Comment 63•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 64•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #60)
Hi, can you please tell me what
# ignore-this-changeset
in the header does? I thought it might suppress blame, but not so, see for example:
https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/accessible/generic/HyperTextAccessible.cpp#1851
Please see https://lists.mozilla.org/pipermail/dev-platform/2019-January/023284.html.
Assignee | ||
Comment 65•5 years ago
|
||
ignore-this-changeset
Comment 66•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a296439a25ff Reformat recent changes to the Google coding style r=Ehsan
Comment 67•5 years ago
|
||
Backed out changeset a296439a25ff (bug 1519636) for frequent Windows cppunit failures CLOSED TREE
Backout revision https://hg.mozilla.org/integration/autoland/rev/28f5cf540df5060eb7d399af223fdb56aa4ea352
Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=248173788&repo=autoland
Sylvestre can you please take a look?
Assignee | ||
Comment 68•5 years ago
|
||
The error is
11:16:26 WARNING - TEST-UNEXPECTED-FAIL | WindowsDllInterceptor | Failed to hook ApiSetQueryApiSetPresence from Api - ms - win - core - apiquery - l1 - 1 - 0.dll
11:16:26 WARNING - TEST-UNEXPECTED-FAIL | TestDllInterceptor.exe | test failed with return code 1
caused by this diff:
TEST_DETOUR_SKIP_EXEC(kernel32.dll, BaseThreadInitThunk) &&
TEST_DETOUR_SKIP_EXEC(ntdll.dll, LdrLoadDll) &&
-
MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(), Api-ms-win-core-apiquery-l1-1-0.dll, ApiSetQueryApiSetPresence, Equals, FALSE, &gEmptyUnicodeString, &gIsPresent) &&
-
MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(),
-
Api - ms - win - core - apiquery - l1 - 1 - 0.dll,
-
ApiSetQueryApiSetPresence, Equals, FALSE,
-
&gEmptyUnicodeString, &gIsPresent) &&
Comment 69•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edbf8267dd4f Reformat recent changes to the Google coding style r=Ehsan
Comment 70•5 years ago
|
||
bugherder |
Assignee | ||
Comment 71•5 years ago
|
||
ignore-this-changeset
Comment 72•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1dbf929c30ae Reformat recent changes to the Google coding style r=Ehsan
Comment 73•5 years ago
|
||
bugherder |
Comment 74•5 years ago
|
||
Assignee | ||
Comment 75•5 years ago
|
||
ignore-this-changeset
Comment 76•5 years ago
|
||
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/98eb0b753429 Mark the entire media/libdav1d directory as third-party; r=andi
Comment 77•5 years ago
|
||
bugherder |
Comment 78•5 years ago
|
||
I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).
Comment 79•5 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #78)
I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).
Thanks. Do you mind filing bugs for these in the future please? :-)
Assignee | ||
Comment 80•5 years ago
|
||
Depends on D35622
Comment 81•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50b6e4480ea0 Reformat recent changes to the Google coding style r=Ehsan https://hg.mozilla.org/integration/autoland/rev/3dc9d0ab9eea Ride along - remove useless ';' r=andi
Assignee | ||
Comment 82•5 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #78)
I spotted the modules/libmar directory listed in .clang-format-ignore, but contrary to the other stuff under modules/, it is not third party code. It should probably be clang-formatted (although there are a few files that are copied from nss and maybe shouldn't?).
Created bug 1563903 for this!
Comment 83•5 years ago
|
||
bugherder |
Assignee | ||
Comment 84•5 years ago
|
||
ignore-this-changeset
Assignee | ||
Comment 85•5 years ago
|
||
Depends on D38057
Assignee | ||
Comment 86•5 years ago
|
||
Depends on D38058
Comment 87•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0edb7e828465 Reformat recent changes to the Google coding style r=Ehsan https://hg.mozilla.org/integration/autoland/rev/bce47e0ee177 Ride along: remove trailing whitespaces r=Ehsan https://hg.mozilla.org/integration/autoland/rev/0a036b8258bf Ride along: Move to the unix CR type r=Ehsan
Assignee | ||
Comment 88•5 years ago
|
||
Comment 89•5 years ago
|
||
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81c861509782 Fix some conflicts r=bustage . CLOSED TREE
Comment 90•5 years ago
|
||
bugherder |
Assignee | ||
Comment 91•5 years ago
|
||
n# ignore-this-changeset
Comment 92•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53bd948e892d Reformat recent changes to the Google coding style r=Ehsan
Comment 93•5 years ago
|
||
bugherder |
Assignee | ||
Comment 94•5 years ago
|
||
Assignee | ||
Comment 95•5 years ago
|
||
ignore-this-changeset
Depends on D47736
Comment 96•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e245551f316b Add some lint tests in the clang-format ignore list r=andi
Comment 97•5 years ago
|
||
bugherder |
Comment 98•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7214f827b7fb Reformat recent changes to the Google coding style r=Ehsan
Comment 99•5 years ago
|
||
bugherder |
Assignee | ||
Comment 100•5 years ago
|
||
Please note that it is the first reformat with clang-format 9
I only saw a fix in the .mm file
ignore-this-changeset
Comment 101•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e50facddb3c9 Reformat recent changes to the Google coding style r=Ehsan
Comment 102•5 years ago
|
||
bugherder |
Assignee | ||
Comment 103•4 years ago
|
||
ignore-this-changeset
Comment 104•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e9c25f6c1ec Reformat recent changes to the Google coding style r=Ehsan
Comment 105•4 years ago
|
||
bugherder |
Assignee | ||
Comment 106•4 years ago
|
||
ignore-this-changeset
Comment 107•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ca91a6eaf8d Reformat recent changes to the Google coding style r=Ehsan
Comment 108•4 years ago
|
||
bugherder |
Assignee | ||
Comment 109•4 years ago
|
||
ignore-this-changeset
Updated•4 years ago
|
Comment 110•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b990267ff717 Automatically reformat recent changes using clang-format r=Ehsan
Comment 111•4 years ago
|
||
bugherder |
Assignee | ||
Comment 112•4 years ago
|
||
ignore-this-changeset
Comment 113•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06762c633bf6 Reformat recent changes to the Google coding style r=Ehsan,kvark
Comment 114•4 years ago
|
||
bugherder |
Assignee | ||
Comment 115•4 years ago
|
||
ignore-this-changeset
Comment 116•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65fc57fa542c Reformat recent changes to the Google coding style r=jgilbert
Comment 117•4 years ago
|
||
bugherder |
Assignee | ||
Comment 118•4 years ago
|
||
ignore-this-changeset
Comment 119•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c369973911e Reformat recent changes to the Google coding style r=andi
Comment 120•4 years ago
|
||
bugherder |
Assignee | ||
Comment 121•4 years ago
|
||
ignore-this-changeset
Comment 122•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c009b34d58a2 Reformat recent changes to the Google coding style r=andi
Assignee | ||
Comment 123•4 years ago
|
||
ignore-this-changeset
Comment 124•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b0a2fb2193f follow up - Reformat recent changes to the Google coding style r=andi
Comment 125•4 years ago
|
||
bugherder |
Assignee | ||
Comment 126•4 years ago
|
||
ignore-this-changeset
Comment 127•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a5d011e7468 Reformat recent changes to the Google coding style r=necko-reviewers,dragana
Comment 128•4 years ago
|
||
bugherder |
Assignee | ||
Comment 129•4 years ago
|
||
ignore-this-changeset
Depends on D79153
Assignee | ||
Comment 130•4 years ago
|
||
ignore-this-changeset
Updated•4 years ago
|
Comment 131•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7db13cef3939 Reformat recent changes to the Google coding style r=andi
Comment 132•4 years ago
|
||
bugherder |
Assignee | ||
Comment 133•4 years ago
|
||
ignore-this-changeset
Comment 134•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c209abd2eac7 Reformat recent changes to the Google coding style r=andi
Comment 135•4 years ago
|
||
bugherder |
Assignee | ||
Comment 136•4 years ago
|
||
# ignore-this-changeset
Comment 137•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e619e7dc301 Reformat recent changes to the Google coding style r=andi
Comment 138•4 years ago
|
||
bugherder |
Assignee | ||
Comment 140•4 years ago
|
||
ignore-this-changeset
Comment 141•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20019504d440 Reformat recent changes to the Google coding style r=andi
Comment 142•4 years ago
|
||
bugherder |
Assignee | ||
Comment 143•4 years ago
|
||
ignore-this-changeset
Comment 144•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0f173a90792 Reformat recent changes to the Google coding style r=andi
Comment 145•4 years ago
|
||
Backed out changeset d0f173a90792 (Bug 1519636) for causing bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/6afa3ab22816e5e6a982f4c2bbcd2c855ae653ee
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=7c5a723760178fd66a55ee7335551a1274039156
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314444788&repo=autoland&lineNumber=2049
Comment 146•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b459c30cad3f Reformat recent changes to the Google coding style r=andi
Assignee | ||
Comment 147•4 years ago
|
||
I mixed two commits, this is fixed now. Sorry!
Comment 148•4 years ago
|
||
bugherder |
Assignee | ||
Comment 149•4 years ago
|
||
ignore-this-changeset
Comment 150•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2a6ca456ddc Reformat recent changes to the Google coding style r=andi
Comment 151•4 years ago
|
||
bugherder |
Assignee | ||
Comment 152•4 years ago
|
||
ignore-this-changeset
Comment 153•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a903337b1be9 Reformat recent changes to the Google coding style r=andi
Comment 154•4 years ago
|
||
bugherder |
Assignee | ||
Comment 155•4 years ago
|
||
ignore-this-changeset
Updated•4 years ago
|
Assignee | ||
Comment 156•4 years ago
|
||
ignore-this-changeset
Comment 157•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf1fbc9e403c Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana
Comment 158•4 years ago
|
||
bugherder |
Assignee | ||
Comment 159•3 years ago
|
||
# ignore-this-changeset
Comment 160•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2977d4891cee Reformat recent changes to the Google coding style r=andi
Comment 161•3 years ago
|
||
bugherder |
Assignee | ||
Comment 162•3 years ago
|
||
ignore-this-changeset
Comment 163•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6aa4d3de0728 Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana
Comment 164•3 years ago
|
||
bugherder |
Assignee | ||
Comment 165•3 years ago
|
||
It is bringing some minor changes
ignore-this-changeset
Comment 166•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c07e6f1f530 Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
Comment 167•3 years ago
|
||
bugherder |
Assignee | ||
Comment 168•3 years ago
|
||
ignore-this-changeset
Comment 169•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34a6f0add455 Reformat recent changes to the Google coding style r=andi
Comment 170•3 years ago
|
||
bugherder |
Assignee | ||
Comment 171•3 years ago
|
||
Updated with clang-format version 11.0.0
ignore-this-changeset
Assignee | ||
Comment 172•3 years ago
|
||
Updated with Debian clang-format version 11.0.1-1
ignore-this-changeset
Comment 173•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/371c029d8743 Reformat recent changes to the Google coding style r=andi
Comment 174•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Assignee | ||
Comment 175•3 years ago
|
||
Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)
ignore-this-changeset
Comment 176•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9544dd3a91ef Reformat recent changes to the Google coding style r=andi
Comment 177•3 years ago
|
||
bugherder |
Assignee | ||
Comment 178•3 years ago
|
||
Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)
ignore-this-changeset
Comment 179•3 years ago
|
||
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/38345c699f68 Reformat recent changes to the Google coding style r=andi,necko-reviewers
Comment 180•3 years ago
|
||
bugherder |
Assignee | ||
Comment 181•3 years ago
|
||
Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)
ignore-this-changeset
Comment 182•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/109b53d16a71 Reformat recent changes to the Google coding style r=necko-reviewers,valentin
Comment 183•3 years ago
|
||
bugherder |
Assignee | ||
Comment 184•3 years ago
|
||
Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)
# ignore-this-changeset
Assignee | ||
Comment 185•3 years ago
|
||
Updated with Debian clang-format version 12.0.0-++rc3-1~exp1
ignore-this-changeset
Comment 186•3 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9797872fe7aa Reformat recent changes to the Google coding style r=andi
Comment 187•3 years ago
|
||
bugherder |
Comment 188•3 years ago
|
||
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)
# ignore-this-changeset
Updated•3 years ago
|
Comment 189•3 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8f02e3a863d Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi
Comment 190•3 years ago
|
||
bugherder |
Comment 191•3 years ago
|
||
Updated with clang-format version 12.0.0 (taskcluster-J6SC83dpSwKvi0nTd5WuMg)
Updated•3 years ago
|
Updated•3 years ago
|
Comment 192•3 years ago
|
||
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)
Updated•3 years ago
|
Updated•3 years ago
|
Comment 193•3 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dbe9bfce447 Reformat recent changes to the Google coding style. r=necko-reviewers,valentin,sylvestre https://hg.mozilla.org/integration/autoland/rev/fc1023cb15a3 Initial reformat of C/C++ code with clang-format version 12.0.0. r=sylvestre
Comment 194•3 years ago
|
||
bugherder |
Comment 195•3 years ago
|
||
Updated with clang-format version 12.0.0 (taskcluster-KEgO7qdgQ8uaewA6NkRnRA)
Comment 196•3 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d19e1260d34d Reformat recent changes to the Google coding style. r=emilio
Comment 197•3 years ago
|
||
bugherder |
Comment 198•3 years ago
|
||
Updated with clang-format version 12.0.0 (taskcluster-FZRqPXamQIOU_i4hF0cAcg)
Comment 199•3 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0eecc59f9ee Reformat recent changes to the Google coding style. r=necko-reviewers,emilio
Comment 200•3 years ago
|
||
bugherder |
Comment 201•3 years ago
|
||
Updated with clang-format version 12.0.1 (taskcluster-dNZqCRqWRTqa6cZxPKxh7Q)
Comment 202•3 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48f5a6cd1340 Reformat recent changes to the Google coding style. r=emilio
Comment 203•3 years ago
|
||
bugherder |
Comment 204•2 years ago
|
||
Updated with clang-format version 13.0.0 (taskcluster-VobPDBQ8RSWourYFs_U38w)
Updated•2 years ago
|
Comment 205•2 years ago
|
||
Reformat with clang-format version 12.0.1 (taskcluster-FYV2l5wGTseBAhiqf8cxfQ)
Updated•2 years ago
|
Comment 206•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d88d0a8e1d38 Reformat recent changes to the Google coding style. r=firefox-build-system-reviewers,mhentges,sylvestre https://hg.mozilla.org/integration/autoland/rev/704f09a557a4 First reformat with clang-format 13.0.0. r=firefox-build-system-reviewers,sylvestre,mhentges
Comment 207•2 years ago
|
||
bugherder |
Comment 208•2 years ago
|
||
Updated with clang-format version 13.0.0 (taskcluster-cMIjs2JaRe6fqM2zK7ZACQ)
Comment 209•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5a71bd269a0 Reformat recent changes to the Google coding style. r=sylvestre
Comment 210•2 years ago
|
||
bugherder |
Comment 211•2 years ago
|
||
Updated with clang-format version 13.0.0 (taskcluster-dn0nWlPhT22vaQNfMnFkSg)
Comment 212•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c08caa5f8504 Reformat recent changes to the Google coding style. r=sylvestre
Comment 213•2 years ago
|
||
Backed out for causing lint failures on multiple files
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
- Failure line 2: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:1 | Empty Lines at end of file (file-whitespace)
Updated•2 years ago
|
Comment 214•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/adb37cc98185 Reformat recent changes to the Google coding style. r=sylvestre
Comment 215•2 years ago
|
||
bugherder |
Comment 216•2 years ago
|
||
Updated with clang-format version 13.0.0 (taskcluster-dIIauZE0TkuXy6_23BQhcw)
Comment 217•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfda402b1582 Reformat recent changes to the Google coding style. r=sylvestre
Comment 218•2 years ago
|
||
bugherder |
Comment 219•2 years ago
|
||
First reformat with clang-format version 13.0.1 (taskcluster-MgYYdzd4SM6nz43RqVFoxw)
ignore-this-changeset
Comment 220•2 years ago
|
||
Updated with clang-format version 13.0.1 (taskcluster-eMexrV3KSgudp2OvUPA6hw)
ignore-this-changeset
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 221•2 years ago
|
||
ignore-this-changeset
Comment 222•2 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5c3a162f850 Reformat recent changes to the Google coding style r=andi,media-playback-reviewers,necko-reviewers,padenot,dragana
Comment 223•2 years ago
|
||
bugherder |
Comment 224•2 years ago
|
||
Updated with clang-format version 13.0.1 (taskcluster-eMexrV3KSgudp2OvUPA6hw)
ignore-this-changeset
Updated•2 years ago
|
Comment 225•2 years ago
|
||
Updated with clang-format version 14.0.5 (taskcluster-YlgDNB2QSm-6a2LDw3kj6A)
ignore-this-changeset
Updated•2 years ago
|
Comment 226•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bc2b595a253 Reformat recent changes to the Google coding style. r=marco
Comment 227•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 228•2 years ago
|
||
Updated with clang-format version 14.0.5 (taskcluster-cAkeFEZXQmihHYDO8Y4hRw)
ignore-this-changeset
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 229•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36b6cd1e3894 Reformat recent changes to the Google coding style. r=media-playback-reviewers,alwu
Comment 230•2 years ago
|
||
bugherder |
Comment 231•2 years ago
|
||
Updated with clang-format version 14.0.5 (taskcluster-ThuAJINyTKOILKeakawQZw)
ignore-this-changeset
Comment 232•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edc6e12812c1 Reformat recent changes to the Google coding style. r=marco
Comment 233•2 years ago
|
||
bugherder |
Comment 234•2 years ago
|
||
Updated with clang-format version 14.0.5 (taskcluster-DydCt-ryTuKvBYw1HQOugw)
ignore-this-changeset
Updated•2 years ago
|
Comment 235•2 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28d5b86884fe Reformat recent changes to the Google coding style. r=glandium
Comment 236•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Updated•2 years ago
|
Comment 237•1 year ago
|
||
Updated with clang-format version 15.0.5 (taskcluster-DZwDzAEyTfOc6FxuNVvlFQ)
ignore-this-changeset
Comment 238•1 year ago
|
||
Updated with clang-format version 15.0.5 (taskcluster-MKK8dHUpQkGfPLA793lizg)
ignore-this-changeset
Updated•1 year ago
|
Comment 239•1 year ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebc57d2ea277 Reformat recent changes to the Google coding style. r=glandium
Comment 240•1 year ago
|
||
bugherder |
Comment 241•11 months ago
|
||
Updated with clang-format version 16.0.2 (taskcluster-f_cdG-1bSlu58g2TVuOBIQ)
ignore-this-changeset
Comment 242•10 months ago
|
||
Updated with clang-format version 16.0.4 (taskcluster-BdnDno4LRs6FtMqXEhTRmQ)
ignore-this-changeset
Updated•10 months ago
|
Updated•7 months ago
|
Updated•7 months ago
|
Comment 243•6 months ago
|
||
Updated with clang-format version 16.0.6 (taskcluster-MKoiQC5YTyWVz1BTt5NOVA)
ignore-this-changeset
Assignee | ||
Comment 244•4 months ago
|
||
Comment 245•4 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8ef574257c7 Remove nbsp in the doc r=firefox-source-docs-reviewers,geckoview-reviewers,ahal,m_kato
Assignee | ||
Comment 246•4 months ago
|
||
clang-format version 17.0.6 (taskcluster-QueHFUviQeyM8Y7r_d7MQQ)
ignore-this-changeset
Comment 247•4 months ago
|
||
bugherder |
Assignee | ||
Comment 248•4 months ago
|
||
Depends on D195370
Comment 249•4 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e06c8b755cc3 Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot
Comment 250•4 months ago
|
||
bugherder |
Comment 251•3 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47051dc89633 Remove nbsp in the perfdoc doc r=perftest-reviewers,aglavic,jmaher
Comment 252•3 months ago
|
||
bugherder |
Description
•