1519648 - screen share selection misaligned; preview and checkbox overlap buttons

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P2)

Description

[Daniel Brooks [:db48x]]

Attachment: two screens side by side: wide aspect ratio and an annoying overlap

This must be a relatively recent regression; I've used this option in months past and it didn't have this problem. It does appear to be caused by the dual-monitor configuration; a quick test on a laptop where it's easier to plug in external displays confirms that the appearance is correct with only one active display.

However, more testing shows that it's actually related to the aspect ratio of the whole group of displays, rather than the number of displays. If I arrange three monitors in an L shape, then the overall aspect ratio is closer to square (well, 16:9 actually) and the selection window is fine. However, if all three monitors are in a horizontal row, then the aspect ratio is very large and the selection window has the most overlap between elements.

I suspect this bug will happen on all platforms.

Comment 1

[Daniel Brooks [:db48x]]

Attachment: three monitors in an L-shape: normal 16:9 aspect ratio, no overlap

Comment 2

[Daniel Brooks [:db48x]]

Attachment: three monitors in a horizontal layout: even wider, even more overlap

Comment 3

[Daniel Brooks [:db48x]]

Attachment: Sharing a wide window in Windows shows the same overlap

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Thanks Daniel! Yes I agree this points perhaps to a simple aspect assumption in the preview pane. Johann, can you confirm?

Marking as regression based on comment 0. To prioritize this it would help to have a regression range.

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

• Last good revision: 045d8fe30f546ab08466c9586ce298e6459c2069 (2017-01-28)
• First bad revision: 71224049c0b52ab190564d3ea0eab089a159a4cf (2017-01-29)
  Pushlog:
  https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=045d8fe30f546ab08466c9586ce298e6459c2069&tochange=71224049c0b52ab190564d3ea0eab089a159a4cf

Please note that on builds older than 2017-01-28 there was no preview for the share screen option.

Comment 6

[Alin Ilea, Desktop QA]

Reproducible on latest Nightly build 70.0a1 (2019-08-27) using Ubuntu 18.04.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

70 is already in beta. While I could still potentially take a patch it isn't critical for 70.
Can you help find an owner for this issue?
I'm not sure in this case the regression range from comment 5 helps, or not.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Assigning to Johann who owns the permission prompt code.

I'm not seeing anything stand out in the regression range, but it appears to be a simple layout bug from unexpected (uncommon) dimensions of the preview pane.

Comment 9

[Johann Hofmann [:johannh]]

Not something I have the capacity to investigate right now. I'll put it on our backlog.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Paul, could you find an owner for this bug? Thanks

Comment 11

[Paul Zühlcke [:pbz]]

Thanks Pascal, I'll look into this.

Comment 12

[Paul Zühlcke [:pbz]]

Attachment: Bug 1519648 - Fixed screen share preview permission prompt layout bug. r=nhnt11

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6158e5023ad4
Fixed screen share preview permission prompt layout bug. r=nhnt11

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6158e5023ad4

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

That looks like a good candidate for an uplift to beta, Paul can you request it? Thanks

Comment 16

[Paul Zühlcke [:pbz]]

Comment on attachment 9106132 [details]
Bug 1519648 - Fixed screen share preview permission prompt layout bug. r=nhnt11

Beta/Release Uplift Approval Request

• User impact if declined: Screen share permission prompt can break on wide aspect ratio and multi monitor setups or when selecting wide aspect ratio windows. If it breaks user can no longer use "remember" checkbox.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open a window and scale so it has wide aspect ratio (small height, large with). Open https://permission.site, select "Screen Share" and select the wide aspect ratio window. The checkbox and allow /deny buttons should not overflow other elements in the prompt.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk, very small CSS fix.
• String changes made/needed:

Comment 17

[Alin Ilea, Desktop QA]

Reproduced the initial issue using an old Nightly build 70.0a1 (2019-08-27).
Verified - fixed on latest Nightly 72.0a1 (2019-11-05) (Build id: 20191105095755) on Ubuntu 18.04 and Windows 10.

Comment 18

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9106132 [details]
Bug 1519648 - Fixed screen share preview permission prompt layout bug. r=nhnt11

Low risk css fix, verified by QA on nightly, uplift approved for 71 beta 8, thanks.

Comment 19

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/92a4c4c217df

Comment 20

[Alin Ilea, Desktop QA]

Verified - fixed on latest Beta 71.0b8 (Build id: 20191107101713) on Ubuntu 18.04 and Windows 10.