1519651 - Fix and re-enable 458637-1.html

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P5)

Description

[Ryan VanderMeulen [:RyanVM]]

dom/base/crashtests/458637-1.html has been disabled for a long time due to timeouts noted in bug 473680. I recently ran a Try push of the test re-enabled and found that it passes reliably on desktop opt builds.

On debug builds, however, it often hits assertion failures on downstream test 561981-2.html (and only that one):
ASSERTION: Destroying a currently-showing document: '!mIsShowing', file dom/base/Document.cpp, line 1392

It also still hits 370 second timeouts on Android 7.0 x86 emulator runs for some reason (but not the 4.3-based ARM emulator runs).

   INFO -  remoteautomation.py | Application ran for: 0:07:20.972425
   INFO -  /data/tombstones does not exist; tombstone check skipped
   INFO -  REFTEST INFO | Downloading symbols from: https://queue.taskcluster.net/v1/task/dsyITcYPQGWwiwrHDEd-jw/artifacts/public/build/target.crashreporter-symbols.zip
   INFO -  REFTEST INFO | Copy/paste: /builds/worker/workspace/build/linux64-minidump_stackwalk /tmp/tmpbkcstv/087e63a0-ac6a-4471-6030-160ad269ca3f.dmp /tmp/tmpAe_io3
   INFO -  REFTEST INFO | Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/087e63a0-ac6a-4471-6030-160ad269ca3f.dmp
   INFO -  REFTEST INFO | Saved app info as /builds/worker/workspace/build/blobber_upload_dir/087e63a0-ac6a-4471-6030-160ad269ca3f.extra
   INFO -  REFTEST PROCESS-CRASH | http://10.0.2.2:8854/tests/dom/base/crashtests/458637-1.html | application crashed [@ nsDocumentViewer::SetDocumentInternal(mozilla::dom::Document*, bool)]
   INFO -  Crash dump filename: /tmp/tmpbkcstv/087e63a0-ac6a-4471-6030-160ad269ca3f.dmp
   INFO -  Operating system: Android
   INFO -                    0.0.0 Linux 3.10.0+ #1 PREEMPT Thu Jan 5 00:46:30 UTC 2017 i686
   INFO -  CPU: x86
   INFO -       GenuineIntel family 6 model 2 stepping 3
   INFO -       1 CPU
   INFO -  GPU: UNKNOWN
   INFO -  Crash reason:  SIGSEGV /SEGV_MAPERR
   INFO -  Crash address: 0x1a8
   INFO -  Process uptime: not available
   INFO -  Thread 11 (crashed)
   INFO -   0  libxul.so!nsDocumentViewer::SetDocumentInternal(mozilla::dom::Document*, bool) [Document.h:85742bc152ece5723104eb7a9c86e074485708d3 : 2600 + 0x0]
   INFO -      eip = 0xd21afbc6   esp = 0xd6ab9120   ebp = 0xd6ab9158   ebx = 0xd5b77ff4
   INFO -      esi = 0xca0a5940   edi = 0xca0a5920   eax = 0x00000000   ecx = 0x00000000
   INFO -      edx = 0x00000000   efl = 0x00010246
   INFO -      Found by: given as instruction pointer in context
   INFO -   1  libxul.so!nsDocumentViewer::SetDocument(mozilla::dom::Document*) [nsDocumentViewer.cpp:85742bc152ece5723104eb7a9c86e074485708d3 : 1896 + 0xe]
   INFO -      eip = 0xd21afb4a   esp = 0xd6ab9160   ebp = 0xd6ab9178   ebx = 0xd5b77ff4
   INFO -      esi = 0xcb569800   edi = 0xcaadd000
   INFO -      Found by: call frame info
   INFO -   2  libxul.so!nsXMLContentSink::OnTransformDone(nsresult, mozilla::dom::Document*) [nsXMLContentSink.cpp:85742bc152ece5723104eb7a9c86e074485708d3 : 352 + 0xc]
   INFO -      eip = 0xd1f1ff70   esp = 0xd6ab9180   ebp = 0xd6ab91c8   ebx = 0xd5b77ff4
   INFO -      esi = 0xcb569800   edi = 0xcaadd000
   INFO -      Found by: call frame info
   INFO -   3  libxul.so!non-virtual thunk to nsXMLContentSink::OnTransformDone(nsresult, mozilla::dom::Document*) [nsXMLContentSink.cpp:85742bc152ece5723104eb7a9c86e074485708d3 : 0 + 0x5]
   INFO -      eip = 0xd1f1ffa0   esp = 0xd6ab91d0   ebp = 0xd6ab91e8   ebx = 0xd5b77ff4
   INFO -      esi = 0xca0d7e00   edi = 0xcb569800
   INFO -      Found by: call frame info
   INFO -   4  libxul.so!txMozillaXSLTProcessor::notifyError() [txMozillaXSLTProcessor.cpp:85742bc152ece5723104eb7a9c86e074485708d3 : 1034 + 0xd]
   INFO -      eip = 0xd1f3fdbd   esp = 0xd6ab91f0   ebp = 0xd6ab9388   ebx = 0xd5b77ff4
   INFO -      esi = 0xca0d7e00   edi = 0xcb569800
   INFO -      Found by: call frame info
   INFO -   5  libxul.so!txMozillaXSLTProcessor::reportError(nsresult, char16_t const*, char16_t const*) [txMozillaXSLTProcessor.cpp:85742bc152ece5723104eb7a9c86e074485708d3 : 964 + 0x7]
   INFO -      eip = 0xd1f3ba74   esp = 0xd6ab9390   ebp = 0xd6ab94d8   ebx = 0xd5b77ff4
   INFO -      esi = 0xca0b6d60   edi = 0xd6ab93a8
   INFO -      Found by: call frame info```

So I'm going to re-enable this test for non-Android opt builds, but leave it disabled for the rest.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

NI myself to see if we can re-enable this now.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Looks good.
https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Crunning%2Cpending%2Crunnable&revision=7d1b8cecabc903dec79acd1495eced0e8cf6bab4

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1519651 - Re-enable 458637-1.html on Android debug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d39500ab6d9d
Re-enable 458637-1.html on Android debug. r=emilio

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d39500ab6d9d