Closed Bug 1519716 Opened 7 years ago Closed 7 years ago

Add pseudoElement state to the Rule state

Categories

(DevTools :: Inspector: Rules, enhancement, P3)

Product:
DevTools
Component:
Inspector: Rules
Type:
enhancement

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

1519716.patch
2.08 KB, patch
rcaliman
: review+
Details | Diff | Splinter Review

In Bug 1478894 while refactoring the different rules section (keyframes, inherited rules, etc) out of the reducer state and into RulesApp, I forgot to add pseudoElement to getRuleState in the reducer so we weren't properly rendering the pseudo element section of the RulesApp.

Attached patch 1519716.patch — — Splinter Review
Attachment #9036211 - Flags: review?(rcaliman)
Attachment #9036211 - Flags: review?(rcaliman) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1abbb5d43328 Add pseudoElement state to the Rule state. r=rcaliman

https://hg.mozilla.org/mozilla-central/rev/1abbb5d43328

Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: