1519750 - [PATCH] Extensions using native messaging silently fail on OpenBSD

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P5)

Description

[William Orr]

Attachment: firefox-native-messaging-obsd.patch

Extensions using some features of native messaging appear to fail on OpenBSD. In the case that they need to launch a helper application, that application fails to launch, and the browser log contains a message about not being able to convert a null pointer to an array.

This appears to be because environ is a NULL pointer when empty, and checking for this prior to filling in the environment before launching the application fixes the issue. Patch attached.

I tested with firefox 64.0.2 on amd64 OpenBSD-current and the KeePassXC browser extension. Before this patch, trying to connect to a database would fail with a timeout, and after functionality worked perfectly.

Comment 1

[William Orr]

Here's the exact error message and stacktrace:

cannot read contents of null pointer ctypes.char.ptr.ptr(ctypes.UInt64("0x0")) subprocess_unix.jsm:117
getEnvironment
resource://gre/modules/subprocess/subprocess_unix.jsm:117:30
InterpretGeneratorResume self-hosted:1255:8 next self-hosted:1210:9 getEnvironment
resource://gre/modules/Subprocess.jsm:143:5
call
resource://gre/modules/Subprocess.jsm:110:21
NativeApp</this.startupPromise<
resource://gre/modules/NativeMessaging.jsm:90:16

Comment 2

[William Orr]

Hey Kris, could you push this change to the try server for testing? Thanks

Comment 3

[Kris Maglione [:kmag]]

This is trivial enough not to need a try run as long as it works locally.

Comment 4

[William Orr]

Cool. In that case, what else do I need to take care of before this can be merged? I've been running this locally for a few days now.

Comment 5

[Kris Maglione [:kmag]]

You just need to add the checkin-needed keyword.

Comment 6

[Cosmin Sabou [:CosminS]]

Hi William, please add a commit message to the patch in the shape of:
Bug 1519750 - <describe what the patch does>. r=kmag
Also please add your name and email address to the patch, so it would be visible in Threeherder and in hg.mozilla.org that you are the author of the patch. I normally use these commands:
hg qrefresh -e (for editing commit message)
hg qrefresh -u "Name <email adress>"
After doing that please add again checkin-needed to the bug and the sheriffs will land the patch.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:will, could you have a look please?

Comment 8

[William Orr]

Attachment: firefox-native-messaging-obsd.patch

Sorry about disappearing, I moved overseas and honestly forgot about this patch. I've updated it with the commit message as requested.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b88d6c20e57
Fix null pointer dereference in native messaging on OpenBSD. r=kmag

Comment 10

[Andreea Pavel [:apavel]]

Hi Will:

from IRC:
pulsebot> Check-in: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b88d6c20e57 - "William Orr - Bug 1519750 - Fix null pointer dereference in native messaging on OpenBSD. r=kmag
1:26 AM
<Kwan> hmm, William Orr should unquote their ui.username in hgrc

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6b88d6c20e57

Comment 12

[Mark Banner (:standard8)]

Dropping old NI as Will is not active recently.