Closed Bug 1519799 Opened 5 years ago Closed 4 years ago

OTR UI: How to display the encryption state of individual messages?

Categories

(Chat Core :: General, enhancement, P1)

enhancement

Tracking

(thunderbird77 fixed)

RESOLVED FIXED
Instantbird 78
Tracking Status
thunderbird77 --- fixed

People

(Reporter: KaiE, Assigned: aleca)

References

Details

Attachments

(3 files, 11 obsolete files)

22.09 KB, patch
clokep
: review+
Details | Diff | Splinter Review
90.54 KB, image/png
Details
12.19 KB, patch
florian
: review+
Details | Diff | Splinter Review

This is a TODO, which should be looked at after we have OTR initially working.

With the old code that we're porting to TB, the conversation window will show a mix of messages exchanged with the buddy, and OTR status messages, such as starting encrypted chat, ending it, verifying peer etc.

Sometimes the first message is sent without encryption, then an OTR session is automatically started, and the window adds information "private conversation started". That means, messages following will be encrypted, but the previous message wasn't.

I think it should be made more obvious, which individual messages were encrypted, and which weren't.

I suspect this would be an improvement over using system messages!

One thing worth noting is that this would need to be done in a way that allows message styles to be involved.

Assignee: nobody → alessandro
Priority: -- → P1

I can do some mock-ups for this, but I'd need a quick overview on how we currently manage the message section and styling.
Patrick, would you be able to point me towards the right file and write down a quick overview of how that area works?

Flags: needinfo?(clokep)

We actually have decent-ish docs on how the message styles work: https://developer.mozilla.org/en-US/docs/Mozilla/Chat_Core/Message_Styles -- I'm not 100% sure this is what you're looking for, but it should be a good start at least!

The theme files live under https://searchfox.org/comm-central/source/mail/components/im/messages

Flags: needinfo?(clokep)
Attached image chat-otr-ui.png (obsolete) —

It's time to tackle also this outstanding OTR issue.
I personally think that the chat UI needs some love and well deserved UI polish, so we could use the occasion to start reorganizing elements and optimize the view for the default style.

In this mock-up proposal, I introduced the following changes:

  • Align the message time to the left to gain more horizontal space for the message.
  • Use our brand colours for the chat names.
  • Use the left space to include smart icons with tooltips indicating the status of a message (encrypted, not-encrypted, not-logged, etc.).

Thoughts?

Attachment #9139552 - Flags: feedback?(richard.marti)
Attachment #9139552 - Flags: feedback?(kaie)
Attachment #9139552 - Flags: feedback?(clokep)

(In reply to Alessandro Castellani (:aleca) from comment #4)

I personally think that the chat UI needs some love and well deserved UI polish, so we could use the occasion to start reorganizing elements and optimize the view for the default style.

Frankly I find the default style unusable. It has too much whitespace in some places, but not enough separation between participants / messages. Florian and I have always encouraged people to use the Bubbles theme. I don't remember why the Thunderbird theme was created to be honest. I'd encourage looking at the other themes to exist while updating this. (It also styles Twitter differently, which really irks me and goes against one of the main tenants of the chat code.)

In this mock-up proposal, I introduced the following changes:

  • Align the message time to the left to gain more horizontal space for the message.

This looks a lot nicer, I wish we could not clip people's names though, it looks very unfinished.

  • Use our brand colours for the chat names.

Just an FYI that the colors of the participants in a multi-user chat are auto-generated based on name. In a one-on-one chat they can use those same colors (I think?) or be hard-coded. The message styles code also supports multiple "variants" of the same theme (e.g. Bubbles has Red-and-Blue, Red-and-Green, etc.)

  • Use the left space to include smart icons with tooltips indicating the status of a message (encrypted, not-encrypted, not-logged, etc.).

The left space is a bit weird since you can:

  • End up with a ton of extra whitespace if the same person sends many messages (or one really long one, I guess).
  • Not end up with enough space if there's a lot of interleaved participants.

I think including icons with tooltips somewhere is a reasonable way to do it. The chat code also has a way to dynamically implement "actions" (look for code that uses getActions()), those are currently down via context menus, not sure if any of that would be useful to include here too. Might get too crowded.

Attachment #9139552 - Flags: feedback?(clokep) → feedback+
Comment on attachment 9139552 [details]
chat-otr-ui.png

The TB theme was on andreasn's demand.

I like your proposal.  The sender name could be on it's own row and the date/text on the next line. Like this, the sender name  can be shown completely and the left white space would be smaller.

For the colours, there is a bug to choose better colours.
Attachment #9139552 - Flags: feedback?(richard.marti) → feedback+

Thank you both for your feedback and suggestions, I'm uploading another mock-up to address everything.
I'd like to not go too much overboard on this bug and keep the main focus on "showing the encryption status of a message" while improving a little bit the default theme.

The left space is a bit weird since you can:
-End up with a ton of extra whitespace if the same person sends many messages (or one really long one, I guess).

I'm not concerned about this as it's a pretty normal outcome in every chat client adopting this type of layout, and it's not wasted white space as it's necessary to visually separate the recipients.

  • Not end up with enough space if there's a lot of interleaved participants.

I'm not quite sure I understood this. Could you show me a screenshot of this scenario?

For the colours, there is a bug to choose better colours.

Cool, I won't tweak them and leave it for that bug.

Attached image otr-chat-status.png (obsolete) —

Moving the recipient name above on its own line solve various problems of visual separation and spacing, good call Richard.

Regarding the context menu, we can take a page from pretty much every other IM clients and show some context buttons on hover.

The left area would be dedicated to showing the time and any extra icons/states specific to that message.

Attachment #9139552 - Attachment is obsolete: true
Attachment #9139552 - Flags: feedback?(kaie)
Attachment #9139586 - Flags: feedback?(richard.marti)
Attachment #9139586 - Flags: feedback?(kaie)
Attachment #9139586 - Flags: feedback?(clokep)

Having either a closed padlock or an open padlock next to each message seems ok.

When looking briefly, the icons don't differ much, "there's a litte grey thing" for both. I wonder if they could be slightly changed so the difference is easier to see.

FX has a icon with a red stroke through the padlock.

Comment on attachment 9139586 [details]
otr-chat-status.png

Looks good as a start of an overhaul.
Attachment #9139586 - Flags: feedback?(richard.marti) → feedback+

I removed the red line because it was getting too much attention.
What if instead we simply don't show anything and we only show the lock when a message is encrypted?
We remove redundancy and clean up that area when dealing with a default status.

Status: NEW → ASSIGNED

(In reply to Alessandro Castellani (:aleca) from comment #8)

Moving the recipient name above on its own line solve various problems of visual separation and spacing, good call Richard.

I agree! That solves a lot of my complaints about the whitespace not being enough of a separator.

Overall I think that looks pretty good! A lock seems reasonable to me, if that is consistent with other locations in our application. If we think we're going to want more than one icon it might make sense to put it below the date instead of next to it, but it looks nice as is now! Good work!

Attachment #9139586 - Flags: feedback?(clokep) → feedback+
Attached patch 1519799-otr-message-status.diff (obsolete) — Splinter Review

I updated the style of the chat thunderbird theme and implemented the new isEncrypted attribute.

I can't seem to find the proper location where an OTR message gets sent, and how to add that flag.
Kai, could you please point me to the right location?

I'm pinging Patrick and Richard to be sure I haven't caused any regressions in styling or readability.

Attachment #9139894 - Flags: feedback?(richard.marti)
Attachment #9139894 - Flags: feedback?(kaie)
Attachment #9139894 - Flags: feedback?(clokep)
Comment on attachment 9139894 [details] [diff] [review]
1519799-otr-message-status.diff

Review of attachment 9139894 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks. Only the text sizes are too small for me.

::: mail/components/im/messages/mail/main.css
@@ +72,4 @@
>  }
>  
> +.ib-msg-txt {
> +  font-size: 0.9em;

Why do you make the normal text smaller. I saw a lot of complaints that the standard size is already too small. I think, this should stay on normal size and the other sizes grow one thenth.
Attachment #9139894 - Flags: feedback?(richard.marti) → feedback+
Attached image smilies.png (obsolete) —

Especially with the smaller font size the smilies are more off centre. Maybe, when you're on changing things in chat code you could also change https://searchfox.org/comm-central/source/chat/themes/conv.css#11 from text-bottom to middle. What do you think?

(In reply to Alessandro Castellani (:aleca) from comment #14)

I updated the style of the chat thunderbird theme and implemented the new isEncrypted attribute.

I can't seem to find the proper location where an OTR message gets sent, and how to add that flag.
Kai, could you please point me to the right location?

There might not be a very simple answer to this question, because there are a lot of callbacks involved.
I remember I had the same problem when I had to implement the logging (or not logging) of encrypted messages.

Could you please look at the commit for bug 1536104 to see if that helps you?

(In reply to Richard Marti (:Paenglab) from comment #15)

Why do you make the normal text smaller. I saw a lot of complaints that the
standard size is already too small. I think, this should stay on normal size
and the other sizes grow one thenth.

Really? That's weird as for me the default font size is incredibly big.
I'm on a HiDPI monitor with large font scaling, and it seems as only this section of Thunderbird gets doubled in size.
I'll revert the sizes to what they were and deal with this on a dedicated bug.

I fixed the emoji alignment.

(In reply to Kai Engert (:KaiE:) from comment #17)

Could you please look at the commit for bug 1536104 to see if that helps you?

Thanks, I'll check it out.

Attached patch 1519799-otr-message-status.diff (obsolete) — Splinter Review

I did it!
Since Kai already set the encrypted attribute in the imConversation, I was able to easily check for it to show/hide the encrypted lock.

Attachment #9139894 - Attachment is obsolete: true
Attachment #9139894 - Flags: feedback?(kaie)
Attachment #9139894 - Flags: feedback?(clokep)
Attachment #9140211 - Flags: review?(kaie)
Attachment #9140211 - Flags: review?(clokep)
Attached image Screenshot from 2020-04-13 12-39-36.png (obsolete) —
Attachment #9139586 - Attachment is obsolete: true
Attachment #9139586 - Flags: feedback?(kaie)
Attached patch 1519799-otr-message-status.diff (obsolete) — Splinter Review

Fixed a tiny padding issue.
If this gets approved, I will upload a follow up to add the lock indicator to all the other message styles.

Attachment #9140211 - Attachment is obsolete: true
Attachment #9140211 - Flags: review?(kaie)
Attachment #9140211 - Flags: review?(clokep)
Attachment #9140535 - Flags: review?(kaie)
Attachment #9140535 - Flags: review?(clokep)

I applied this locally to test it. I merged with the changes from bug 1549938.

The behavior looks good to me in general. Omitting the padlock for unencrypted messages seems ok to me.

I've tested the scenario described in bug 1519796 comment 18. The message is shown with the padlock, although it wasn't actually sent out with encryption. (In particular, it wasn't sent out at all.) However, the message is promised to NOT be sent without protection, so the behavior seems acceptable to me (the system messages explain that the message has not been sent (yet)). The bug here is rather that we display such queued/pending messages normally. Maybe a separate bug should be filed to request "show pending/queued outgoing messages differently".

Comment on attachment 9140535 [details] [diff] [review]
1519799-otr-message-status.diff

I think the chat code should be reviewed by Patrick, but feedback+ from me.
Attachment #9140535 - Flags: review?(kaie) → feedback+

(In reply to Kai Engert (:KaiE:) from comment #22)

The bug here is rather that we display such queued/pending messages normally. Maybe a separate bug should be filed to request "show pending/queued outgoing messages differently".

I think this is something we've wanted, just never implemented. Sounds separate to me!

Comment on attachment 9140535 [details] [diff] [review]
1519799-otr-message-status.diff

Review of attachment 9140535 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good overall! I left a few minor comments that should be fixed before landing this though.

A couple of other thoughts that don't have clear actions:
* I didn't really review all of main.css, just pointed out things that jumped out to me.
* I believe the html files in themes purposefully didn't have whitespace in them for efficiency reasons. Whether this was a real optimization or not I'm unsure. If so, it might make more sense to make that change as part of the build process.

::: chat/locales/en-US/conversations.properties
@@ +78,5 @@
>  messenger.conversations.selections.systemMessagesTemplate=%time% - %message%
>  messenger.conversations.selections.contentMessagesTemplate=%time% - %sender%: %message%
>  messenger.conversations.selections.actionMessagesTemplate=%time% * %sender% %message%
> +
> +message.status=Message encrypted

Please add a comment above this for localizers to explain what "encrypted" means here.

::: chat/modules/imThemes.jsm
@@ -46,5 @@
>  XPCOMUtils.defineLazyGetter(this, "gTimeFormatter", () => {
>    return new Services.intl.DateTimeFormat(undefined, {
>      hour: "2-digit",
>      minute: "2-digit",
> -    second: "2-digit",

I believe this is going to modify ALL message themes. I don't believe we should be making this change. And should be using the `time{format}` replacement in the theme instead. See https://developer.mozilla.org/en-US/docs/Mozilla/Chat_Core/Message_Styles#Replacement_in_both_messages_and_status_messages

@@ +481,5 @@
> +  },
> +  encryptedMessage(aMsg) {
> +    return Services.strings
> +      .createBundle("chrome://chat/locale/conversations.properties")
> +      .GetStringFromName("message.status");

Generating this string bundle for every encrypted message sounds like it will have poor performance.

::: mail/components/im/jar.mn
@@ -24,5 @@
>      content/messenger/chat/chat-imconv.js                (content/chat-imconv.js)
>      content/messenger/chat/chat-conversation-info.js     (content/chat-conversation-info.js)
>      content/messenger/chat/toolbarbutton-badge-button.js (content/toolbarbutton-badge-button.js)
>  % skin messenger-messagestyles classic/1.0 %skin/classic/messenger/messages/
> -	skin/classic/messenger/messages/mail/Bitmaps/minus-hover.png          (messages/mail/Bitmaps/minus-hover.png)

I think these are also used in the Bubbles theme.

::: mail/components/im/messages/mail/main.css
@@ -5,5 @@
>  #Chat {
>    white-space: normal;
>  }
>  
> -/* The "#chat " is required to override "#Chat *" from conv.css */

Is this comment still useful?

@@ +6,5 @@
>    white-space: normal;
>  }
>  
> +#Chat .sessionstart-ruler {
> +  border-top: 1px solid ThreeDDarkShadow;

This seems to duplicate a rule below for `.sessionstart-ruler`. Is it necessary in both places?

::: mail/components/im/themes/chat.css
@@ +753,5 @@
>  /* from instantbird/themes/blist.css */
>  richlistitem[is="chat-group-richlistitem"] .twisty {
>    padding-top: 1px;
> +  width: 10px; /* The image's width is 8 pixels */
> +  height: 10px;

These changes look unrelated to this bug? I'm a bit confused at what this is doing here.
Attachment #9140535 - Flags: review?(clokep) → review-

Tanks for the review.

Generating this string bundle for every encrypted message sounds like it will have poor performance.

How would you approach this issue? Do we want to have a string at all for that icon?

These changes look unrelated to this bug? I'm a bit confused at what this is doing here.

Sorry, those slipped in by mistake.

(In reply to Alessandro Castellani (:aleca) from comment #26)

Tanks for the review.

Generating this string bundle for every encrypted message sounds like it will have poor performance.

How would you approach this issue? Do we want to have a string at all for that icon?

Something like this: https://searchfox.org/comm-central/rev/2131bede09ff0e7273bc77f669150491cd0d7685/chat/components/src/imConversations.jsm#17-19

Comment on attachment 9140535 [details] [diff] [review]
1519799-otr-message-status.diff

Review of attachment 9140535 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/im/messages/mail/Incoming/Content.html
@@ +1,1 @@
> +<div class="%messageClasses%" data-prpl="%service%">

This file (and the others next to it) were intentionally whitespace free because these HTML snippets will be duplicated hundreads of times, and we don't want to generate plenty of HTML text nodes containing whitespace.

Thanks Florian for the heads up, I'll remove the whitespace.

Should there be a readme file next to those files in the same directory, that explains that rule?

Attached patch 1519799-otr-message-status.diff (obsolete) — Splinter Review

Fixed everything.
The bubbles theme uses its own minus and plus PNGs in within the theme's folder.

Attachment #9140535 - Attachment is obsolete: true
Attachment #9140808 - Flags: review?(clokep)

I'm not sure how the Content.html is hooked up, but is it possible to just use Fluent? I.e. just add data-l10n-id?

Any chance of reviewing/landing this before the next beta?
I'm coordinating a user testing session of the OTR implementation and having this improvement would be great.

Comment on attachment 9140808 [details] [diff] [review]
1519799-otr-message-status.diff

Review of attachment 9140808 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/modules/imThemes.jsm
@@ +484,5 @@
>  
>      return msgClass.join(" ");
>    },
> +  encryptedClass(aMsg) {
> +    return !aMsg.encrypted ? "" : "show";

Any reason not to use `return aMsg.encrypted ? "show": "";`? Seems slightly simpler.

::: mail/components/im/jar.mn
@@ -24,5 @@
>      content/messenger/chat/chat-imconv.js                (content/chat-imconv.js)
>      content/messenger/chat/chat-conversation-info.js     (content/chat-conversation-info.js)
>      content/messenger/chat/toolbarbutton-badge-button.js (content/toolbarbutton-badge-button.js)
>  % skin messenger-messagestyles classic/1.0 %skin/classic/messenger/messages/
> -	skin/classic/messenger/messages/mail/Bitmaps/minus-hover.png          (messages/mail/Bitmaps/minus-hover.png)

We should remove these files from `mail/installer/allowed-dupes.mn` if there is only one copy now!
Attachment #9140808 - Flags: review?(clokep) → review-

Updated.

Attachment #9140808 - Attachment is obsolete: true
Attachment #9141406 - Flags: review?(clokep)
Comment on attachment 9141406 [details] [diff] [review]
1519799-otr-message-status.diff

I unfortunately wasn't able to get the icon to show up (I think OTR is busted on my self-built Thunderbird). Looks good though. The changes to the theme are nice! :)
Attachment #9141406 - Flags: review?(clokep) → review+

Just to confirm, the lock works for me.
I also launched a try run to see if I busted something: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b5e906bff305055eed77f12f4cc2edd6c9dca4c5

Attachment #9139910 - Attachment is obsolete: true
Attachment #9140212 - Attachment is obsolete: true

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/911aa4dd69ad
Improve the default message style UI and show the OTR encryption status of individual messages. r=clokep

Comment on attachment 9141406 [details] [diff] [review]
1519799-otr-message-status.diff

[Approval Request Comment]
I'm requesting an uplift to Beta because URA Design is organizing an OTR usability test for next week.
I'd would be better to let the auditors use a Beta with the latest UI and UX improvements to the OTR feature to prevent false negatives or risk to have a report focused on sections we already fixed or improved.
Attachment #9141406 - Flags: approval-comm-beta?
Comment on attachment 9141406 [details] [diff] [review]
1519799-otr-message-status.diff

taking to keep the OTR iteration train moving
Attachment #9141406 - Flags: approval-comm-beta? → approval-comm-beta+

This is a follow up patch taking care of all the other themes.

Attachment #9141897 - Flags: review?(clokep)
Attached image chat-styles.png (obsolete) —

Here's a screenshot with all the chat styles with encrypted messages.
They're not "perfect", but as a first implementation I think this is acceptable.
We can later improve those styles in dedicated bugs.

(In reply to Alessandro Castellani (:aleca) from comment #42)

Thanks for the screenshots. The encrypted/secure nature of the message seems attached to the name of the sender, so for message themes that group messages together, I think it would make more sense to show the lock icon before the name of the sender, rather than before every messages.

nit: Spacing issues (only relevant if you keep the icons as they are) : there's not enough horizontal padding on both sides of the lock icons on the screenshot of the Bubbles theme. On the third theme in your screenshot, the vertical alignment of the lock icon in the first message of a message group seems a bit off.

Comment on attachment 9141897 [details] [diff] [review]
1519799-otr-encryption-status.diff

Review of attachment 9141897 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/im/messages/bubbles/Incoming/Content.html
@@ +1,4 @@
>  <div class="bubble %messageClasses%" data-senderColor="%senderColor%">
>  <div class="indicator">
>  <p class="pseudo">%sender%<span class="time"> - %time{%H:%M}%</span></p>
> +<label title="%encryptedMessage%" class="encrypted %encryptedClass%"></label>

It seems we should have an 'encrypted' class be part of %messageClasses% when a message is encrypted. And the icon can then be displayed using CSS and :before.
Adding a label in the markup for every single message seems wasteful. Even more so as the title string will be duplicated everytime.
Comment on attachment 9141406 [details] [diff] [review]
1519799-otr-message-status.diff

Review of attachment 9141406 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/modules/imThemes.jsm
@@ +487,5 @@
> +  encryptedClass(aMsg) {
> +    return aMsg.encrypted ? "show" : "";
> +  },
> +  encryptedMessage(aMsg) {
> +    return bundle.GetStringFromName("message.status");

I see this is using a lazy getter, but the lazy getter should be for the actual string, not just for the bundle, as calling GetStringFromName for every message that needs to be displayed will be inefficient.

Thanks Florian for the feedback.
I'll upload a follow up patch to address all your valid points.

Comment on attachment 9141897 [details] [diff] [review]
1519799-otr-encryption-status.diff

Per Florian's comments.
Attachment #9141897 - Flags: review?(clokep) → review-

Patch updated to implement the icon as pseudo element inline the sender name.
I also removed the string as title tag since that wasn't working, and implemented the OTR Status: Message encrypted row in the chat buddy tooltip, in case the message is encrypted.

Attachment #9141897 - Attachment is obsolete: true
Attachment #9141900 - Attachment is obsolete: true
Attachment #9145162 - Flags: review?(florian)
Attachment #9145162 - Flags: review?(clokep)
Comment on attachment 9145162 [details] [diff] [review]
1519799-otr-encryption-status.diff

Review of attachment 9145162 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Looks much better :-).

::: chat/content/chat-tooltip.js
@@ +336,5 @@
>  
>        this.addRow(this.bundle.GetStringFromName("buddy.account"), account.name);
>  
> +      // Add encryption status.
> +      if (document.tooltipNode.classList.contains("message-encrypted")) {

I'm not sure when this will be shown to users. Are we currently showing tooltips when hovering the message sender for every message?

::: chat/locales/en-US/imtooltip.properties
@@ +5,5 @@
>  buddy.username=Username
>  buddy.account=Account
>  contact.tags=Tags
> +
> +otr.tag=OTR Status:

I think the other labels used for this tooltip don't include the trailing ':'.

::: mail/components/im/messages/bubbles/main.css
@@ +143,5 @@
>    min-height: 13px;
>    background-image: linear-gradient(to bottom, rgba(255, 255, 255, 0), rgba(0,0,0,0.18));
>  }
>  
> +.encrypted .ib-sender {

This is an expensive selector. Would .ib-sender.message-encrypted give the same result?

::: mail/components/im/messages/mail/main.css
@@ +69,5 @@
>  }
>  
> +.message.outgoing + .message.outgoing,
> +.message.incoming + .message.incoming {
> +    margin-block: 0;

nit: incorrect indent here.
Attachment #9145162 - Flags: review?(florian) → feedback+

Thanks for the detailed review, I fixed all the issues you pointed out.

I'm not sure when this will be shown to users. Are we currently showing tooltips when hovering the message sender for every message?

Yes, we're showing a tooltip with the user info and profile image when the mouse hovers over the sender's name.

Attachment #9145162 - Attachment is obsolete: true
Attachment #9145162 - Flags: review?(clokep)
Attachment #9145646 - Flags: review?(florian)
Comment on attachment 9145646 [details] [diff] [review]
1519799-otr-encryption-status.diff

Review of attachment 9145646 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me from code inspection; I haven't tested this locally.
Attachment #9145646 - Flags: review?(florian) → review+
Target Milestone: --- → Instantbird 78

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3fa5a7d06f89
Implement the encrypted lock icon for all the chat message styles. r=florian

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

We should likely uplift that additional patch so all of this bug is fixed in 78.

Comment on attachment 9145646 [details] [diff] [review]
1519799-otr-encryption-status.diff

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: Only some themes will show the encrypted status of messages, which is confusing.
Testing completed (on c-c, etc.): This has been on nightly for a couple of days.
Risk to taking this patch (and alternatives if risky): It is possible that there could be a perf impact or the additional themes could break, but I believe this would be found very quickly.
Attachment #9145646 - Flags: approval-comm-beta?
Comment on attachment 9145646 [details] [diff] [review]
1519799-otr-encryption-status.diff

Yes, let's continue the iteration on OTR
Attachment #9145646 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.