1519822 - Crash in mozilla::dom::quota::(anonymous namespace)::OriginParser::HandleToken when opening Storage Inspector on a IPv6 URL

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P3)

Description

[mail]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

• go to a IPv6 URL (e.g. https://[2606:4700:4700::1111]/)
• open "Storage" Tab in Web Inspector

Actual results:

Firefox Crashed: https://crash-stats.mozilla.com/report/index/51b47cc8-056b-4f2c-bed0-0dfb80190114

Expected results:

Cookies etc should be listed

Comment 1

[Tom Tung [:tt, :ttung]]

I guess it's because OriginParser doesn't support this kind of URL. Since it's part of the initialization failure, I am going to take and fix it.

Comment 2

[Tom Tung [:tt, :ttung]]

although it's a crash, but the number is low. I would probably work on this after fixing other crashes and issues.

Comment 3

[Tom Tung [:tt, :ttung]]

Andrew and Jan told me that I should be careful of transferring issues while parsing into the disk. If we have this trouble, it is possible to have two different origins but having the same directory.

Comment 4

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #3)

Andrew and Jan told me that I should be careful of transferring issues while parsing into the disk. If we have this trouble, it is possible to have two different origins but having the same directory.

Also, if someone has already had a directory from this origin, I should handle that properly.

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1519822 - Support IPv6 URL on OriginParser;

The supporting format for IPv6 URL based on https://www.ietf.org/rfc/rfc2732.txt

Comment 6

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d8ad78f306da3895d8d828b184c5e50f0b4ae27

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00816819d381
Support IPv6 URL on OriginParser; r=asuth

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/00816819d381

Comment 9

[Ryan VanderMeulen (PTO, back July 27)]

AFAICT, we're not hitting this in the wild, so we can let the fix ride the trains. Feel free to nominate for Beta uplift if you feel strongly otherwise, however.