1519859 - Cannot get FileInfo while doing structured clone

Status: NEW

(Core :: Storage: IndexedDB, enhancement, P2)

Description

[Tom Tung [:tt, :ttung]]

This is the follow-up bug for bug 1432133. Note that the patch there won't actually fix the problem, but just avoiding from crashing. We should somehow find the real issue inside.

We could keep understanding how many users dropping into this by the telemetry.

Comment 1

[Tom Tung [:tt, :ttung]]

Telemetry result: https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2019-06-29&include_spill=0&keys=__none__!__none__!__none__&max_channel_version=nightly%252F69&measure=SCALARS_IDB.FAILURE.FILEINFO_ERROR&min_channel_version=nightly%252F66&processType=*&product=Firefox&sanitize=0&sort_by_value=0&sort_keys=submissions&start_date=2019-05-20&table=0&trim=1&use_submission_date=0

Comment 2

[Tom Tung [:tt, :ttung]]

I had a xpcshell test using a corrupted database to reproduce hitting this issue. The next step is that using manual created test to reproduce this. I guess we only need to put different file ids into table object_data and table file for creating the corrupted database.

My plan for this is to remove the idb folder as our first step.
I might need to call:

• QuotaClient::AbortOperations(aOrigin)
• Clear the idb folder
• QuotaClient::OnOriginClearCompleted(aOrigin)

Now, the first entry point where we found the issue is at:
https://searchfox.org/mozilla-central/rev/f372470e10c8cb0691681603a1d6324dee5b3b8a/dom/indexedDB/ActorsParent.cpp#8435

If it eventually goes to content process (DeserializeStructuredCloneFile), then we probably wants to call ClearOrigin or something like that on QMS.

Comment 3

[Tom Tung [:tt, :ttung]]

I'm not actively working on this so drop the assignee.