1519880 - Refactor FrameInfo for interpreter changes

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Jan de Mooij [:jandem]]

Baseline's FrameInfo class stores the script and keeps track of the compiler's virtual stack.

Most of this doesn't apply to the interpreter, so I want to split FrameInfo in InterpreterFrameInfo and CompilerFrameInfo (with a common FrameInfo base class). Then CompilerFrameInfo will store the script and the virtual stack and we can use the type system to ensure InterpreterFrameInfo doesn't depend on any of this.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1519880 part 1 - Stop exposing StackValue* to BaselineCodeGen. r?djvj!

The interpreter won't use the virtual stack and StackValue, so we need to
refactor things a bit so we don't call frame.peek(x) outside the FrameInfo class.

StackValue will be just an implementation detail of CompilerFrameInfo in the
next patch.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1519880 part 2 - Split Baseline's FrameInfo class in CompilerFrameInfo and InterpreterFrameInfo. r?djvj!

InterpreterFrameInfo is just a very simple interface on top of masm.
CompilerFrameInfo maintains the virtual stack based on the script it's
compiling.

Depends on D16479

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f24ec43206d7
part 1 - Stop exposing StackValue* to BaselineCodeGen. r=djvj
https://hg.mozilla.org/integration/autoland/rev/d11bb3bd8195
part 2 - Split Baseline's FrameInfo class in CompilerFrameInfo and InterpreterFrameInfo. r=djvj

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f24ec43206d7
https://hg.mozilla.org/mozilla-central/rev/d11bb3bd8195