1519905 - Either set [clickthrough=never] on XUL browser elements or modify NodeAllowsClickThrough to automatically return false for browsers so they don't respond to mouse events when in an unfocused window

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Brian Grinstead [:bgrins]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1441935#c46. I forgot to do this in Bug 1441935.

Comment 1

[Brian Grinstead [:bgrins]]

I'm going to try the NodeAllowsClickThrough change as opposed to setting the attribute on browser elements since it seems a bit simpler.

It appears this attribute is only used by XUL trees, scrollbars, resizers, and browsers so a potential follow up could be to remove support for the attribute altogether and change the attribute lookup at https://searchfox.org/mozilla-central/rev/b29663c6c9c61b0bf29e8add490cbd6bad293a67/dom/events/EventStateManager.cpp#2823 into an IsAnyOfXULElements check.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1519905 - Always return false in NodeAllowsClickThrough for browser elements;r=mstange

This prevents mouse events from firing on browsers in unfocused windows. It used to be done
with the [clickthrough=never] attribute set from XBL content.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36b1b39a9775
Always return false in NodeAllowsClickThrough for browser elements;r=mstange

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/36b1b39a9775