1519910 - Consider renaming ChromeBrowsingContext

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

Currently this is too easy to confuse with a BrowsingContext of type Chrome. Perhaps we want to have it be called BrowsingContextParent or similar.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

ni? farre for thoughts

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Another naming idea: ManagerBrowsingContext

The class is only used in the parent process, but it isn't exactly "sided", but rather extended storage and information which only the parent process should have access to, so making it clear that it's the type for BrowsingContext used by the Manager might make things more clear.

Comment 3

[Andreas Farre [:farre]]

Yeah, I'd totally go for a better name. I agree that Parent implies sidedness, but I'm also kind of allergic to classes named Manager :) And manager also makes me think that there's only one instance. And that goes for Parent as well, since we usually have Parent/Child mean a 1:1 relationship across process boundaries.

We could bring back AbstractBrowsingContext, but that's every bit as vague as MBC. More suggestions:

• SyncedBrowsingContext, as it is synced
• ExtendedBrowsingContext, as in it has more data than regular BC
• OwnerBrowsingContext, in that ... I don't know, is ownery
• ReplicatedBrowsingContext, in that it is where BC's are replicated
• CanonicalBrowsingContext, as in that it is what we consider to be the true representation of a BC tree
• CheckedBrowsingContext, as in that is here we check that stuff is valid

I like CanonicalBrowsingContext, CheckedBrowsingContext and lastly AbstractBrowsingContext. But in the end, anything but ChromeBrowsingContext.

Did I mention that I've got a degree in bikeshedding?

Comment 4

[Nika Layzell [:nika] (ni? for response)]

I do like CanonicalBrowsingContext, so I'm OK with that. GlobalBrowsingContext or something like that could work too?

Comment 5

[Andreas Farre [:farre]]

Attachment: Bug 1519910 - Rename ChromeBrowsingContext to CanonicalBrowsingContext.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de20609039ac
Rename ChromeBrowsingContext to CanonicalBrowsingContext. r=nika

Comment 7

[Andreas Farre [:farre]]

Canonical it is

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/de20609039ac