1519917 - Consider <menulist> with sizetopopup unset equal to sizetopopup="pref"

Status: RESOLVED FIXED

(Core :: XUL, task, P3)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This was part of bug 1518932 but I figured this should be landed first so the bug can work on with artifact builds.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1519917 - Consider <menulist> with sizetopopup unset equal to sizetopopup="pref"

sizetopopup is set to "pref" by default by the menulist XBL binding, however
when converting the binding to custom element, it did not set the attribute value
at a time that is early enough.

This patch updates nsMenuPopupFrame and nsMenuFrame so that it considers
<menulist> with unset sizetopopup attribute as equal to "pref" to avoid
the problem above.

The problem can be detected by the reftest
layout/reftests/xul/menulist-shrinkwrap-2.xul
in which the parent box won't update its width even when <menulist>
reframes with the correct sizetopopup value.

The sizetopopup attribute is never meant to be set dynamically;
the fix here does not allow us to do so.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66fc49cd43f507aa38d386ab3dbff0f05d235a49

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7484d3a99bfc
Consider <menulist> with sizetopopup unset equal to sizetopopup="pref" r=NeilDeakin

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/7484d3a99bfc