1520040 - Port bug 1486521 - compose/src/nsMsgComposeService.cpp:287:5: error: functions marked as MOZ_CAN_RUN_SCRIPT can only be called from functions also marked as MOZ_CAN_RUN_SCRIPT

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Jorg K (CEST = GMT+2)]

This seems to come from here:
https://hg.mozilla.org/mozilla-central/rev/93c0ed8f3690#l2.17

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1520040-MOZ_CAN_RUN_SCRIPT.patch

I'm not sure this can be seen on Windows, here's a try push for Linux:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9ffbd15301c34381feab64ba3cd37b58be9000fe

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1520040-MOZ_CAN_RUN_SCRIPT.patch (v2)

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=dfd2ad9d333394586aa65f93b817830b8ac4ba0a

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c5966ac10c4
Port bug 1486521: Add MOZ_CAN_RUN_SCRIPT to two functions in nsMsgComposeService.cpp. rs=bustage-fix

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9036467 [details] [diff] [review]
1520040-MOZ_CAN_RUN_SCRIPT.patch (v2)

I think you're doing this wrong. "Note that MOZ_CAN_RUN_SCRIPT only be applied to function declarations, not definitions."

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9036467 [details] [diff] [review]
1520040-MOZ_CAN_RUN_SCRIPT.patch (v2)

See the previous comment. I could be wrong, but that's how I read it.

Comment 6

[Jorg K (CEST = GMT+2)]

OK, I'll shift it around. nsMsgComposeService::OpenComposeWindow() is generated from the IDL.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9036467 [details] [diff] [review]
1520040-MOZ_CAN_RUN_SCRIPT.patch (v2)

r- is not so helpful since it already landed and I won't back it out (since it would bust two platforms).

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1520040-follow-up.patch

OK, switched this over to MOZ_CAN_RUN_SCRIPT_FOR_DEFINITION. Since one function is generated from the IDL I saw no point to put it onto the declaration for the the other one (to avoid searching around).

We'd better make sure it compiles before landing this:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9202560ba7e27b16fdbd0653b4c6a33365d55364

You might want to use it for the next M-C merge.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a55410ab6adb
Follow-up: use MOZ_CAN_RUN_SCRIPT_FOR_DEFINITION for function definitions. r=me

Comment 10

[Jorg K (CEST = GMT+2)]

Sorry, the build was busted due to bug 1520944, so I used this to trigger a new one. I hope you agree with the fix.