Port bug 1486521 - compose/src/nsMsgComposeService.cpp:287:5: error: functions marked as MOZ_CAN_RUN_SCRIPT can only be called from functions also marked as MOZ_CAN_RUN_SCRIPT

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk
Thunderbird 66.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee: nobody → jorgk
Target Milestone: --- → Thunderbird 66.0
Attachment #9036467 - Flags: review?(geoff)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4c5966ac10c4
Port bug 1486521: Add MOZ_CAN_RUN_SCRIPT to two functions in nsMsgComposeService.cpp. rs=bustage-fix

Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Comment on attachment 9036467 [details] [diff] [review]
1520040-MOZ_CAN_RUN_SCRIPT.patch (v2)

See the previous comment. I could be wrong, but that's how I read it.
Attachment #9036467 - Flags: review?(geoff) → review-
Summary: Port 1486521 - compose/src/nsMsgComposeService.cpp:287:5: error: functions marked as MOZ_CAN_RUN_SCRIPT can only be called from functions also marked as MOZ_CAN_RUN_SCRIPT → Port bug 1486521 - compose/src/nsMsgComposeService.cpp:287:5: error: functions marked as MOZ_CAN_RUN_SCRIPT can only be called from functions also marked as MOZ_CAN_RUN_SCRIPT

OK, I'll shift it around. nsMsgComposeService::OpenComposeWindow() is generated from the IDL.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 9036467 [details] [diff] [review]
1520040-MOZ_CAN_RUN_SCRIPT.patch (v2)

r- is not so helpful since it already landed and I won't back it out (since it would bust two platforms).
Attachment #9036467 - Flags: review-

OK, switched this over to MOZ_CAN_RUN_SCRIPT_FOR_DEFINITION. Since one function is generated from the IDL I saw no point to put it onto the declaration for the the other one (to avoid searching around).

We'd better make sure it compiles before landing this:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9202560ba7e27b16fdbd0653b4c6a33365d55364

You might want to use it for the next M-C merge.

Attachment #9037398 - Flags: review?(geoff)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a55410ab6adb
Follow-up: use MOZ_CAN_RUN_SCRIPT_FOR_DEFINITION for function definitions. r=me

Status: REOPENED → RESOLVED
Closed: 7 months ago7 months ago
Resolution: --- → FIXED

Sorry, the build was busted due to bug 1520944, so I used this to trigger a new one. I hope you agree with the fix.

Attachment #9037398 - Flags: review?(geoff) → review+
You need to log in before you can comment on or make changes to this bug.