1520081 - Use the minimum scale size even if the minimum-scale in viewport meta tag is greater than 1

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

There is a test case that Botond created [1], but the test case doesn't work as expected by simply drop the check in UpdateMinimumScaleSize(), so I am going to handle it in a follow-up bug (this).

[1] https://phabricator.services.mozilla.com//D15347#inline-89264

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I've finished writing a patch with a test case. But unfortunately the test case fails intermittently. I need to debug what happens in the failure case.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc37c301323a5800ced260076c7faadcbafe888c

Comment 2

[Hiroyuki Ikezoe (:hiro)]

It turns out we need to wait for a scroll event of Visual Viewport instead of just waiting for waitUntilApzStable. It's pretty natural. (I didn't notice it) :)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dec5de102e74abe2c9bcf7ad6e03eae1c2da5bdf

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1520081 - Use the minimum scale size even if the minimum-scale in viewport meta tag is greater than 1.0. r=botond

Comment 4

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b370f071f6e99e7252ae9c5ee905972f763de00

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c3a041f077f
Use the minimum scale size even if the minimum-scale in viewport meta tag is greater than 1.0. r=botond

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8c3a041f077f