1520138 - Table CSS borders have changed

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Toad]

Attachment: borderTable.zip

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

When you use a <table> with the "border" attribute with a value different than 0, even if it is on a non-HTML5 website, then the CSS border properties are not applied.

This only occurs in the current Nightly release (66). Something else has also been changed, when using the CSS border-bottom in the last <td> of the table, please see the attached files.

Actual results:

Please see the PNG in the attached zip.

Expected results:

Please see the PNG in the attached zip.

Comment 1

[Gingerbread Man]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=70030bab1073c89c41311368a224178257cb9068&tochange=c5b713000513a2cdc1fdbc70aeb8f7d78bd687b2

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1520138 - Fix border-style conflict resolution in border-collapsed tables.

Bug 1509717 removed Gecko's definition of StyleBorderStyle to use the Rust one.

The Rust version was ordered in a different way, and the table code relied on
the order in order to build the mapping for border conflict resolution.

Simplify this mapping now that border constants are ordered in terms of
priority, see the comment on top of `enum BorderStyle`.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Thank you very much for the report. Apparently our test coverage for border-collapsed tables sucks :(

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b2f212b3947
Fix border-style conflict resolution in border-collapsed tables. r=dholbert

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9036599 [details]
Bug 1520138 - Fix border-style conflict resolution in border-collapsed tables.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1509717

User impact if declined: Some tables could look different.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Simple fix that restores the previous behavior in a slightly simpler way.

String changes made/needed: none

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9b2f212b3947

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14928 for changes under testing/web-platform/tests

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9036599 [details]
Bug 1520138 - Fix border-style conflict resolution in border-collapsed tables.

[Triage Comment]
Returns us to previous behavior and adds new tests to avoid future breakage. Approved for 65.0b12.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/01bd5daff7e0