Closed Bug 1520158 Opened 2 years ago Closed 2 years ago

Avoid scene rebuilding for image updates

Categories

(Core :: Graphics: WebRender, enhancement, P3)

66 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(1 file)

When an image posts a FRAME_UPDATE notification, we invalidate the frame, and rebuild the display list. There is no real reason for this, and we can use the same mechanism as for animated images to avoid the scene rebuild. This is useful when images are slowly decoding due to the size of the image, or the network speed.

This was easy to do, so might as well land it:

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ed4e1e69e536b6d5e9bf6f9e32091ed016d9a4b

Probably marginal benefit though.

Assignee: nobody → aosmond
Priority: -- → P3
Version: 65 Branch → 66 Branch
We already avoid scene rebuilding for animated image frame updates, but
we can easily apply this to still images. If the decoding is happening
slowly and in chunks for some reason (really large image, slow network),
then we may save some work.
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/096cd49afd33
Avoid scene rebuilding for image frame updates if possible. r=jrmuizel
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Depends on: 1527085
You need to log in before you can comment on or make changes to this bug.