Avoid scene rebuilding for image updates

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

66 Branch
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 months ago

When an image posts a FRAME_UPDATE notification, we invalidate the frame, and rebuild the display list. There is no real reason for this, and we can use the same mechanism as for animated images to avoid the scene rebuild. This is useful when images are slowly decoding due to the size of the image, or the network speed.

Assignee

Comment 1

5 months ago

This was easy to do, so might as well land it:

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ed4e1e69e536b6d5e9bf6f9e32091ed016d9a4b

Probably marginal benefit though.

Assignee: nobody → aosmond
Priority: -- → P3
Version: 65 Branch → 66 Branch
Assignee

Comment 2

5 months ago
We already avoid scene rebuilding for animated image frame updates, but
we can easily apply this to still images. If the decoding is happening
slowly and in chunks for some reason (really large image, slow network),
then we may save some work.

Comment 3

5 months ago
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/096cd49afd33
Avoid scene rebuilding for image frame updates if possible. r=jrmuizel

Comment 4

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee

Updated

4 months ago
Depends on: 1527085
You need to log in before you can comment on or make changes to this bug.