1520166 - Transition in-tree jcjones/u2f-hid-rs to vendoring mozilla/authenticator-rs v0.2.5

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P3)

Description

[J.C. Jones [:jcj] (he/they)]

Primarily picking up https://github.com/jcjones/u2f-hid-rs/pull/75. Might want to wait until 67.

Comment 1

[Bastien Orivel [:eijebong]]

Anything new on this ? It's the last thing preventing the removal of rand 0.3. I'm not sure if doing it would be ok with you since you're assigned

Comment 2

[J.C. Jones [:jcj] (he/they)]

I haven't had time to pick this up, been busy with Fennec. I'll be getting it in this release, but I was hoping to also remove u2f-hid-rs from-tree and vendor-in authenticator-rs as part of it.

I just released 0.2.5 to crates.io for the purpose. If you'd like to take on swapping from in-tree to vendoring though before I get there, feel free to! Sorry for the delay.

https://crates.io/crates/authenticator

Comment 3

[Bastien Orivel [:eijebong]]

No problem with the delay, I'll do it if I have some time before you do. I was just hesitant because the issue was assigned and I'm not familiar with the bugzilla customs

Comment 4

[J.C. Jones [:jcj] (he/they)]

Fair enough. Consider this permission to take it -- it's assigned to me mostly as a reminder to Do It Do It Do It. :)

Comment 7

[Bastien Orivel [:eijebong]]

This is now blocked on https://github.com/mozilla/authenticator-rs/pull/91

Other than that, everything went smoothly, I'll push my patch once 0.2.6 gets released

Comment 8

[J.C. Jones [:jcj] (he/they)]

https://crates.io/crates/authenticator updated to 0.2.6 -- thank you!

Comment 9

[Bastien Orivel [:eijebong]]

Attachment: Bug 1520166 - Part 1: Use a vendored version of authenticator. r?jcj

This replaces the in-tree u2fhid (which has been renamed to
authenticator) by the published crate.

Comment 10

[Bastien Orivel [:eijebong]]

Attachment: Bug 1520166 - Part 2: revendor dependencies. r?jcj

Depends on D32221

Comment 11

[Bastien Orivel [:eijebong]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e32c20f4b5522bf7a5c766b715ad8973a61730d4

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34d9d707fcd5
Part 1: Use a vendored version of authenticator. r=jcj
https://hg.mozilla.org/integration/autoland/rev/ad1be1252928
Part 2: revendor dependencies. r=jcj

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/34d9d707fcd5
https://hg.mozilla.org/mozilla-central/rev/ad1be1252928