1520226 - Make GeckoView set permanentKey on <browser> elements for Marionette

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Nick Alexander :nalexander [he/him]]

Just like Bug 787203, but for GeckoView. Setting permanentKey on <browser> elements lets Marionette reference them in the standard manner.

Comment 1

[Chris Peterson [:cpeterson]]

Geoff, which Android tests require Marionette? Just some Fennec UI tests?

IIUC, Marionette for GeckoView was WONTFIX'd in bug 1411658.

Comment 2

[Geoff Brown [:gbrown]]

web-platform-tests use marionette. We came across the permanentKey issue when trying to run wpt against geckoview (currently wpt only runs against fennec). I believe 1411658 was about enabling a wider range of marionette functionality; wpt on geckoview almost works...just needs a few tweaks like this.

Comment 3

[Chris Peterson [:cpeterson]]

P2 because wpt bug 1496773 is P2.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is for geckoview but not Fennec. As such it should block bug 1496773 but not bug 1500509.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1520226 - Make GeckoView set permanentKey on <browser> elements for Marionette. r?snorp

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d40794bc9cf
Make GeckoView set permanentKey on <browser> elements for Marionette. r=snorp

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1d40794bc9cf