Closed Bug 1520229 Opened 9 months ago Closed 9 months ago

[css-logical] Implement the inset/inset-block/inline shorthands

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: mats, Assigned: mats)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

To my surprise, this doesn't fix the logical-box-inset.html failures
like the padding/margin patches did. I couldn't really find anything
wrong with the test though. I checked that these shorthands works as
intended in devtools though, fwiw.

Attachment #9036640 - Flags: review?(emilio)
Comment on attachment 9036640 [details] [diff] [review]
[css-logical] Implement the inset-block/inline shorthands

Review of attachment 9036640 [details] [diff] [review]:
-----------------------------------------------------------------

You were missing the 'inset' shorthand. I submitted a separate patch for that, so this looks good to me.
Attachment #9036640 - Flags: review?(emilio) → review+
Summary: [css-logical] Implement the inset-block/inline shorthands → [css-logical] Implement the inset/inset-block/inline shorthands
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30dc251e2657
[css-logical] Implement the inset-block/inline shorthands.  r=emilio

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

You were missing the 'inset' shorthand. I submitted a separate patch for
that, so this looks good to me.

I didn't intend to fix 'inset' in this bug, but yeah, the failures at
the start in the .ini file are about 'inset', not 'inset-block/inline'
as I mistakenly thought in comment 1.

I'll send an intent-to-ship about all of these in a moment FYI.

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/824c36902a37
[css-logical] Implement the inset shorthand. r=mats

Docs completed; Rachel Andrew created the docs a while ago.

I've now submitted a PR to update the compat data too:
https://github.com/mdn/browser-compat-data/pull/3706

I also added a note to the Fx66 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/66#CSS

You need to log in before you can comment on or make changes to this bug.