1520229 - [css-logical] Implement the inset/inset-block/inline shorthands

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Mats Palmgren (inactive)]

https://drafts.csswg.org/css-logical/#propdef-inset-inline

Comment 1

[Mats Palmgren (inactive)]

Attachment: [css-logical] Implement the inset-block/inline shorthands

To my surprise, this doesn't fix the logical-box-inset.html failures
like the padding/margin patches did. I couldn't really find anything
wrong with the test though. I checked that these shorthands works as
intended in devtools though, fwiw.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1520229 - [css-logical] Implement the inset shorthand. r=mats

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9036640 [details] [diff] [review]
[css-logical] Implement the inset-block/inline shorthands

Review of attachment 9036640 [details] [diff] [review]:
-----------------------------------------------------------------

You were missing the 'inset' shorthand. I submitted a separate patch for that, so this looks good to me.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30dc251e2657
[css-logical] Implement the inset-block/inline shorthands.  r=emilio

Comment 5

[Mats Palmgren (inactive)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

You were missing the 'inset' shorthand. I submitted a separate patch for
that, so this looks good to me.

I didn't intend to fix 'inset' in this bug, but yeah, the failures at
the start in the .ini file are about 'inset', not 'inset-block/inline'
as I mistakenly thought in comment 1.

Comment 6

[Mats Palmgren (inactive)]

I'll send an intent-to-ship about all of these in a moment FYI.

Comment 7

[Mats Palmgren (inactive)]

https://groups.google.com/forum/#!topic/mozilla.dev.platform/8dvTjUpgcqU

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/30dc251e2657

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/824c36902a37
[css-logical] Implement the inset shorthand. r=mats

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/824c36902a37

Comment 11

[Chris Mills [:cmills]]

Docs completed; Rachel Andrew created the docs a while ago.

I've now submitted a PR to update the compat data too:
https://github.com/mdn/browser-compat-data/pull/3706

I also added a note to the Fx66 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/66#CSS