1520309 - mach try fuzzy has a weird interaction with more under MozillaBuild on Windows

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

STR:

start a MozillaBuild terminal and switch to your local source dir
./mach try fuzzy
select your jobs and press enter

Expected:
We can see something going on and the command eventually returns to the command prompt

Actual:
The terminal goes blank. Running process explorer shows that work is happening (and in fact my job is correctly submitted), but hg.exe has spawned more.com and appears to be blocked on that.

Once it looks like hg has entered a quiescent state, I can kill more.com and then I am finally returned to my command prompt.

Comment 2

[(not currently active) Ted Mielczarek]

It looks like Mercurial defaults to more on Windows if you don't have a pager configured:
https://www.mercurial-scm.org/repo/hg/file/0f2b8d51bfdf/mercurial/scmwindows.py#l19
https://www.mercurial-scm.org/repo/hg/file/0f2b8d51bfdf/mercurial/rcutil.py#l23
https://www.mercurial-scm.org/repo/hg/file/0f2b8d51bfdf/mercurial/ui.py#l1123

mach try fuzzy is calling check_working_directory:
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/tools/tryselect/push.py#75-81

which winds up calling HgRepository.working_directory_clean:
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/python/mozversioncontrol/mozversioncontrol/__init__.py#337-347

which effectively runs hg status .... We are setting HGPLAIN=1 in the environment of the hg process, which is supposed to disable paging:
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/python/mozversioncontrol/mozversioncontrol/__init__.py#224

Per the Mercurial source:
https://www.mercurial-scm.org/repo/hg/file/0f2b8d51bfdf/mercurial/ui.py#l1114
https://www.mercurial-scm.org/repo/hg/file/0f2b8d51bfdf/mercurial/ui.py#l808

What version of Mercurial are you using? Do you have the pager extension explicitly enabled in your ~/.hgrc or ~/Mercurial.ini?

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #2)

What version of Mercurial are you using?
4.8.2

Do you have the pager extension explicitly enabled in your ~/.hgrc or ~/Mercurial.ini?
Negative.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

I reproduced this again today, and using Process Explorer I examined the environment for hg. HGPLAIN is not present in its environment.

Comment 5

[(not currently active) Ted Mielczarek]

(In reply to Aaron Klotz [:aklotz] from comment #4)

I reproduced this again today, and using Process Explorer I examined the environment for hg. HGPLAIN is not present in its environment.

Interesting! Did you catch the commandline of the process? Is it running hg status?

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

c:\Users\dblohm7\mozilla-build\python\Scripts\hg.exe push-to-try -m "FuzzyPushed via mach try fuzzy"

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1520309: Set HGPLAIN env var when running hg push-to-try; r=ahal!

If there are a large number of untracked files in the working directory, hg
will attempt to print them all out with the default pager. This does not
interact very will with commands that are built atop this functionality. We
set HGPLAIN=1 so that the underlying hg will not attempt to use a pager.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4002fa5fe7bd
Set HGPLAIN env var when running hg push-to-try; r=ahal

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4002fa5fe7bd