1520311 - Remove binutils from mingw-clang build script

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Georg noticed that binutils doesn't seem to be used anymore. A try run confirms that nothing seems to break. I believe we can remove it.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Sorry; the observation was that we can use llvm-nm instead of binutil's nm.

The original need for binutils' nm was we needed it to perform the NSModule check; but we switched that over to use readobj when we started generating pdbs.

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1520311 - Remove binutils from the mingw-clang toolchain build r?jacek,Build

Comment 3

[Jacek Caban]

I think the patch is fine for nm itsel, but we should probably resolve bug 1471698 before going forward with this patch. It has a pending patch patch adding binutils objcopy and strip to the toolchain. While it should be possible to do the build without them (clang-cl toolchain doesn't have them), I think you mentioned at some point that it's needed to run tests for some reason (bug 1475994). llvm-objcopy exists, but doesn't support Windows targets yet, so if we want to use it, we will need binutils for that.

Comment 4

[Jacek Caban]

Comment on attachment 9036715 [details] [diff] [review]
Bug 1520311 - Remove binutils from the mingw-clang toolchain build r?jacek,Build

llvm-objcopy supports COFF files, to it looks like we won't need binutils for that. The patch looks fine then.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

This needs more investigation and work.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?

Comment 8

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

No change. Can we disable the bot for this bug?

Comment 9

[Sylvestre Ledru [:Sylvestre]]

302 to calixte

Comment 10

[Calixte Denizet (:calixte)]

I'll fix that, sorry for the noise.

Comment 11

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Done as part of Bug 1471698