1520326 - UrlbarProviderUnifiedComplete should set context.preselected in more cases than it currently does

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Drew Willcoxon :adw]

After implementing bug 1520317, I saw that the preselection doesn't happen in some cases, notably when the heuristic result is a search suggestion. e.g., just type "foo", and the first result isn't preselected. On the other hand, if the first result is an autofill result, then it is preselected.

I think the problem is that UrlbarProviderUnifiedComplete sets context.preselected only if the first result has defaultIndex == 0. That doesn't seem to match how the legacy urlbar works. It doesn't take defaultIndex into account when preselecting the heuristic result, and afaik we don't want to change that behavior in quantumbar.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1520326 - Set context.preselected when the first result is the heuristic result, regardless of result.defaultIndex.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbfa31396fa4
Set context.preselected when the first result is the heuristic result, regardless of result.defaultIndex. r=mak

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/cbfa31396fa4