Closed Bug 1520383 Opened Last year Closed 11 months ago

devtools/client/inspector/markup/test/browser_markup_events* failures when using `allFrames: true` for a ChildActor

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Whiteboard: [fixed by bug 1042082])

Attachments

(2 files)

browser_markup_events*.js tests fail if I register a ChildActor with allFrames: true because the developer tools inspector sees the pagehide/pageshow events added by ActorManagerChild.jsm on the window[1]. See attachment 9036482 [details] [diff] [review] for a minimal patch to register an allFrames: true actor and reproduce the problem.

It's possible that bug 1520075 will change the SingletonDispatcher class to avoid this problem, otherwise maybe we need to filter these events out of the developer tools?

:gl, do you know if we already try to filter out certain chrome/webext events from showing in the event tooltip? I didn't see any of that happening in [2] but perhaps it's somewhere else.

[1] https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/toolkit/modules/ActorManagerChild.jsm#187-188
[2] https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/devtools/server/actors/inspector/node.js#411

Flags: needinfo?(gl)

Hey Mike, you might know more about this area than myself.

Flags: needinfo?(gl) → needinfo?(mratcliffe)

Thanks for letting us know about this bug... I will add it to my list.

Flags: needinfo?(mratcliffe)

Does that mean you consider it a devtools bug that it doesn't filter out these non-site event listeners? This is blocking bug 1474143 from landing so a solution or workaround would be good.

Flags: needinfo?(mratcliffe)

@MattN I think we can filter out the events.

If this is blocking I can prioritize it.

Flags: needinfo?(mratcliffe)
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED

Actually, chrome event listeners shouldn't be listed in the content debugger but we should list them in the browser debugger.

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
See Also: 1042082
Whiteboard: [fixed by bug 1042082]

This already matches the behaviour for unofficial (e.g. local and asan) builds.

They also permafail on local builds. I believe the reason is the different default value of devtools.chrome.enabled: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/devtools/shared/preferences/devtools-shared.js#26-30

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/a7b269adadca
Default devtools.chrome.enabled to false for inspector markup tests. r=bgrins
Assignee: mratcliffe → MattN+bmo
Status: REOPENED → ASSIGNED
Component: Async Tooling → Inspector
Product: Toolkit → DevTools
Status: ASSIGNED → RESOLVED
Closed: 11 months ago11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.