1520423 - ComputePostFilterExtents and nsCSSFilterInstance::SetBounds are malloc heavy

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Testcase is to move mouse over https://kangax.github.io/compat-table/esnext/

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1520294

https://perfht.ml/2FBxTUe
and
https://perf-html.io/public/5efdb443905498eaba6b8479e64ab16fc7601712/calltree/?globalTrackOrder=0-1-2&hiddenGlobalTracks=1&hiddenLocalTracksByPid=3149-0-1-2-3-4~3336-0-1~3287-0-1&invertCallstack&localTrackOrderByPid=3149-0-1-2-3-4~3336-0-1~3287-0-1~&search=ComputePost&thread=9&v=3

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

AutoTArray should work here, but I'm not sure about the best size for it.

Comment 2

[Robert Longson [:longsonr]]

Me neither, it's the filter chain size which is unbounded in markup. Maybe guess at 8 to start, most filter chains aren't that big.

Comment 3

[Robert Longson [:longsonr]]

For CSS property filters the most common chain size might even be 1, though not for ComputePostFilterExtents as that does SVG filters too I believe.

Comment 4

[Jonathan Watt [:jwatt]]

(In reply to Robert Longson [:longsonr] from comment #2)

Me neither, it's the filter chain size which is unbounded in markup. Maybe guess at 8 to start, most filter chains aren't that big.

That seems about right to me too.

Comment 5

[Robert Longson [:longsonr]]

Attachment: Bug 1520423 - Use AutoTArray in filter code r=dholbert

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/264cb1246df7
Use AutoTArray in filter code r=emilio

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/264cb1246df7