Closed
Bug 1520495
Opened 7 years ago
Closed 7 years ago
Crash count table does not detect uplift links in Markdown comments
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kohei, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The crash count table functionality (previously a Firefox extension) parses bug comments to detect uplift links posted after a patch is landed. See Bug 1516426 Comment 9 for example. But due to the brand-new Markdown support, this detection doesn’t work anymore.
https://github.com/mozilla/crash-stop-addon/blob/master/webextension/content.js#L142
Basically the selector here has to be .comment-text[data-ismarkdown=“true”] > p > a for markdown comments. I’ll send a PR to fix this.
|
Reporter | |
Comment 1•7 years ago
|
||
|
|
Reporter | |
Comment 2•7 years ago
|
||
Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 3•7 years ago
|
||
calixte told me it didn't work.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 4•7 years ago
|
||
(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #3)
calixte told me it didn't work.
On snap. Why not?
|
|
||
Updated•7 years ago
|
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•7 years ago
|
||
Already merged to master. This was due to the removal of attributes in the first PR.
|
||
Updated•6 years ago
|
Assignee: kohei.yoshino → nobody
Component: Extensions: BMO → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•