Closed Bug 1520570 Opened 4 years ago Closed 4 years ago

build breakpad client in separate stage

Categories

(Socorro :: General, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

When we merged the changes to always build the breakpad client, it increased the image size from ~400mb to ~750mb. That affects a few things including docker pulls in deployment.

This bug covers using multi-stage builds so that the final image doesn't have depot_tools and all that stuff that building the breakpad client requires.

Priority: -- → P2
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/bc6724bd5df1443c9adc82e52a31265931ce2b39
fix bug 1520570: switch to multi-stage docker image builds

This moves building breakpad client into a separate docker image build stage.
That way all its intermediary build tools and files don't swamp the final
socorro_app image and make it super huge.

This also adds support for "NOCACHE=1 make build" which will build the
docker image with --no-cache flag. I do that so often that it seemed
prudent to codify it in the Makefile and save myself some time.

This also tweaks the .dockerignore file to ignore breakpad client
build bits during the COPY which might show up in a local dev environment
when working on updating the breakpad client.

https://github.com/mozilla-services/socorro/commit/ab271f3ac5b5eccc7d949dbae68526190be9c12d
Merge pull request #4781 from willkg/1520570-multi-stage

fix bug 1520570: switch to multi-stage docker image builds
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.