1520629 - Long press on link doesn't load firefox context menu (iOS 12.2 beta)

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Image-1.jpg

On occasion, Firefox iOS will get into a state where the context menu being opened is not the Firefox one I expect; instead it seems to be the default webview.

I reported a different issue that also involved the default share sheet in Bug 1480563.

Comment 1

[Justin D'Arcangelo [:justindarc]]

ni? catalin to try and find STR

Comment 2

[Catalin Suciu [:csuciu]]

no luck so far. will keep trying.

Comment 3

[Simon Basca [:SimonB]]

Reproducible on iOS 12.2b1 (16E5181f) with Firefox 15.0 (13791). Also reproducible on Firefox 14.0 (12646) released version.

Comment 4

[:garvan]

https://github.com/mozilla-mobile/firefox-ios/pull/4503

Comment 5

[:garvan]

WebKit bug for this https://bugs.webkit.org/show_bug.cgi?id=193366
and the patch https://bug-193366-attachments.webkit.org/attachment.cgi?id=358946

It is still useful to land our patch which re-tries to hook into the longpress gesture, and seem like it might defend against cases where the hook isn't being installed.

Comment 6

[:garvan]

Fixed on master, it will be useful to know how robust this approach is.

Comment 7

[Catalin Suciu [:csuciu]]

Verifying as fixed on 16.0 (14386).

Comment 8

[:garvan]

For posterity, doing this ContextMenuHelper.swift seems to work:

    func monitorForReplacement() {
        DispatchQueue.main.asyncAfter(deadline: .now() + 0.2) {
            if self.gestureRecognizerWithDescriptionFragment("ContextMenuHelper") == nil  {
                self.replaceWebViewLongPress()
            }
            self.monitorForReplacement()
        }
    }

That is, watching the tab every 200 ms to see if our ContextMenuHelper is present, and if not, install it.
I see no usable WKWebView event that will let us know when the content process has swapped (at which point the custom gesture handler is uninstalled).