[css-logical] Implement the flow-relative border-radius properties

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

({dev-doc-complete})

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(2 attachments)

Comment on attachment 9037346 [details] [diff] [review]
part 1 - Add plumbing for handling physical/logical corner values

Review of attachment 9037346 [details] [diff] [review]:
-----------------------------------------------------------------

::: servo/components/style/logical_geometry.rs
@@ +171,5 @@
>          }
>      }
>  
>      #[inline]
> +    pub fn physical_sides_to_corner(block_side: PhysicalSide, inline_side: PhysicalSide) -> PhysicalCorner {

nit: Let's not make this `pub`.

@@ +187,5 @@
> +    }
> +
> +    #[inline]
> +    pub fn start_start_physical_corner(&self) -> PhysicalCorner {
> +        WritingMode::physical_sides_to_corner(self.block_start_physical_side(),

nit: Let's use block indentation like the rest of the file, so:

WritingMode::physical_sides_to_corner(
    self.block_start_physical_side(),
    self.inline_start_physical_side(),
)

here and elsewhere.

::: servo/components/style/properties/helpers.mako.rs
@@ +841,5 @@
>  <%def name="logical_setter_helper(name)">
>      <%
>          side = None
>          size = None
> +        corner = None

Ugh, I did not remember how ugly this code was, damn :(
Attachment #9037346 - Flags: review?(emilio) → review+
Attachment #9037348 - Flags: review?(emilio) → review+

Comment 5

4 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c39aa6dfd458
part 1 - Add plumbing for handling physical/logical corner values.  r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/2406b20fb105
part 2 - [css-logical] Implement the flow-relative border-radius properties.  r=emilio

Comment 6

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14955 for changes under testing/web-platform/tests

Updated

3 months ago
Depends on: 1528176

Updated

3 months ago
Blocks: 1528176
No longer depends on: 1528176
You need to log in before you can comment on or make changes to this bug.