[remote-dbg-next] CSS: change variable name --base-distance to --base-unit

RESOLVED FIXED in Firefox 66

Status

enhancement
P1
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: ogasidlo, Assigned: ogasidlo)

Tracking

(Blocks 1 bug)

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

As the golbal variable --base-distance is indicating a per Photon defined unit of 4px, which we use (or multiple units of it) for various definitions in our application, I suggest to change the variable name to --base-unit to make it more understandable.

Priority: P5 → P3
Assignee

Comment 1

4 months ago

rename global variable --base-distance to --base-unit to improve understanding of code

Assignee

Updated

4 months ago
Assignee: nobody → ogasidlo
Priority: P3 → P1
Assignee

Updated

4 months ago
Status: NEW → ASSIGNED

Comment 2

4 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecb5dd148378
rename variable name --base-distance to --base-unit, r=ladybenko

Comment 3

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.