Closed Bug 1520768 Opened 5 years ago Closed 5 years ago

[remote-dbg-next] CSS: change variable name --base-distance to --base-unit

Categories

(DevTools :: about:debugging, enhancement, P1)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: ogasidlo, Assigned: ogasidlo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1520768 - rename variable name --base-distance to --base-unit, r=ladybenko
47 bytes, text/x-phabricator-request
Details | Review

As the golbal variable --base-distance is indicating a per Photon defined unit of 4px, which we use (or multiple units of it) for various definitions in our application, I suggest to change the variable name to --base-unit to make it more understandable.

Priority: P5 → P3

rename global variable --base-distance to --base-unit to improve understanding of code

Assignee: nobody → ogasidlo
Priority: P3 → P1
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecb5dd148378
rename variable name --base-distance to --base-unit, r=ladybenko

https://hg.mozilla.org/mozilla-central/rev/ecb5dd148378

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: