Remove will-navigate/navigate navPayload relic attribute

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
4 months ago
6 days ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: dt-fission)

Attachments

(1 attachment)

Assignee

Description

4 months ago

Target class currently set a "navPayload" attribute on will-navigate and navigate events:
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/devtools/client/framework/target.js#660,664

This is only used by the console:
https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/devtools/client/webconsole/utils/messages.js#349
Console codebase uses this attribute to identify that this is a navigation event. Actually in the case of this code, it will only be the will-navigate event dispatched from here:
https://searchfox.org/mozilla-central/rev/bee8cf15c901b9f4b0c074c9977da4bbebc506e3/devtools/client/webconsole/webconsole-output-wrapper.js#478-488

This navPayload is always empty. It is most likely a relic from non-e10s codepath. We are still having some leftover of non-e10s here and there.

Console should distinguish the packet differently and we should remove this antic attribute.

Assignee

Updated

4 months ago
Whiteboard: dt-fission
Assignee

Comment 1

4 months ago

It looks like a relic of the ancient times, probably specific to non-e10s codepath
which degraded over time and there is still a couple of leftover here and there.

For now the output wrapper was passing over the will-navigate event and make it so
that it looked like a "cached" packet. Which it isn't.
So instead, flag a meaningful "type" attribute and handle this packet directly in
transformPacket.

Comment 2

4 months ago
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bda17f8f936
Remove navPayload from will-navigate/navigate events. r=nchevobbe

Comment 3

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.