1520772 - Construct the WebExtension target front before instantiating the Target object

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

For now, the Web Extension target actor was constructed late, from Target.attach.
So that we were instantiating the Target class with a front which wasn't a target front until we call Target.attach that will replace the activeTab with the final, real web exntension target front.

https://searchfox.org/mozilla-central/rev/bee8cf15c901b9f4b0c074c9977da4bbebc506e3/devtools/client/framework/target.js#574-584

This is bad as we assume that activeTab is the target front, and that prevent us from merging target front and target classes.
So we should make it so that this code in attach is executed before instantiating the Target object.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1520772 - Construct the WebExtension target front before instantiating the Target object.

Depends on D15828

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11325875967a
Construct the WebExtension target front before instantiating the Target object. r=yulia

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/11325875967a