1520819 - Improve RDM handling of meta viewport

Status: RESOLVED WORKSFORME

(DevTools :: Responsive Design Mode, enhancement, P2)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: rdm-touch-disable.mp4

Without full page refreshes RDM (with touch simulation) can behave in odd ways.

Attached is a video where RDM leaves scrollbars in the middle of the page after disabling it.

Even though there is a setting to refresh the page when touch simulation is toggled or the user agent changes, this page refresh does not happen on closing RDM.

The site I'm using here is google.com, which set's <meta content="width=device-width,minimum-scale=1.0" name="viewport"> for touch devices.

2 problems I see:

• RDM only functions as expected when the page is refreshed after entering it
• Closing RDM needs another page refresh to make the page behave normally

At a minimum, I think we need to have a page refresh when closing RDM and either of the two options is enabled.

Thinking it through though, I would love for us to have a way to handle those situations without a page refresh. It would be great for the changes panel, and Chrome can also do without it. A refresh should be the very last resort.

Comment 1

[Brad Werth [:bradwerth]]

Once Bug 1521814 lands, this issue will need the pref dom.meta-viewport.enabled set to true in order to properly test it.

Comment 2

[Brad Werth [:bradwerth]]

(In reply to Brad Werth [:bradwerth] from comment #1)

Once Bug 1521814 lands, this issue will need the pref dom.meta-viewport.enabled set to true in order to properly test it.

Update: the relevant pref is devtools.responsive.metaViewport.enabled.

Comment 3

[Brad Werth [:bradwerth]]

This was likely fixed by Bug 1501665. Would you please retest in Nightly?

Comment 4

[Martin Balfanz [:mbalfanz]]

seems ok now!