Fix handling of Symbol-named properties on objects with named setters

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P2
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 wontfix, firefox67 fixed)

Details

Attachments

(1 attachment)

We never implemented the changes from https://github.com/heycam/webidl/issues/175

Per spec these should just go directly to the expando object; we were ignoring them instead.

Depends on: 1489308

Marking P2 as I figure this is coming in soon? If not can move to P3.

Priority: -- → P2

Is this blocked on anything?

Flags: needinfo?(bzbarsky)

Yes, see the "Depends on" field. The exact diff here depends on the document.open changes to the test expectations to apply.

I could spend a bunch of time and reorder, but since this is non-urgent, I don't think it's worth the time.

Flags: needinfo?(bzbarsky)

Comment 5

3 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4dcf351df9b8
Fix handling of Symbol-named properties on objects with named setters.  r=qdot

Comment 6

3 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02de7c233aaa
followup.  Mark some more tests as passing.  r=bzbarsky

Comment 7

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.