Closed
Bug 1520831
Opened 5 years ago
Closed 5 years ago
Fix handling of Symbol-named properties on objects with named setters
Categories
(Core :: DOM: Bindings (WebIDL), enhancement, P2)
Core
DOM: Bindings (WebIDL)
Tracking
()
RESOLVED
FIXED
mozilla67
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
We never implemented the changes from https://github.com/heycam/webidl/issues/175
|
Assignee | |
Comment 1•5 years ago
|
||
Per spec these should just go directly to the expando object; we were ignoring them instead.
|
||
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
Marking P2 as I figure this is coming in soon? If not can move to P3.
Priority: -- → P2
|
|
Assignee | |
Comment 4•5 years ago
|
||
Yes, see the "Depends on" field. The exact diff here depends on the document.open changes to the test expectations to apply.
I could spend a bunch of time and reorder, but since this is non-urgent, I don't think it's worth the time.
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4dcf351df9b8 Fix handling of Symbol-named properties on objects with named setters. r=qdot
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02de7c233aaa followup. Mark some more tests as passing. r=bzbarsky
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4dcf351df9b8
https://hg.mozilla.org/mozilla-central/rev/02de7c233aaa
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•