1520914 - New System : Blank page persists after "enable" toggle is turned on

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Brahmini Nagabandi]

Attachment: Screen Shot 2019-01-17 at 11.09.39 AM.png

about:newtab#devtools-ds goes blank after turning ON the toggle "enabled" switch.
This happens only for the very first time on the system (Mac/Windows) , and the next time when toggled ON/OFF, page is not blank. (cached)

Steps to Reproduce:

1. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true in about:config
2. Visit about:newtab#devtools-ds. Ensure you see devtools
3. Try turning ON the new tab experiment off/on via the "enabled" checkbox

Actual Result:
about:newtab#devtools-ds goes blank

Expected Result:
Blank page not expected.

cc: @Kate Hudson :k88hudson

Comment 1

[Punam Dahiya [:pdahiya]]

On debugging looks like render is failing when feeds[feed.url] is undefined

https://github.com/mozilla/activity-stream/blob/master/content-src/components/ASRouterAdmin/ASRouterAdmin.jsx#L71

Error in console:
Dispatch error: TypeError: feeds[feed.url] is undefined

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4687

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/108b37488788f64ef905c797d1bd7a879e835a3c
Bug 1520914 - AS devtools blank page fix on first discovery stream enable (#4687)

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5f9e44c1bbd5

Comment 5

[Brahmini Nagabandi]

QA Results :

Created a new profile and checked on Mac and Windows 10 Pro.

No more blank page.

Closing as verified.