1520996 - Add dedicate ParseNode subclass for property definition and use enum kind instead of JSOp to specify getter/setter.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai] (away until 08-17)]

Bug 1501577 added emitter helper for object/class, but the consumer of it is still using JSOp to determine whether the property is getter/setter/other.
We should add another variant of ParseNode subclass for property definition (including class methods/fields) and use enum kind to tell what it is.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Bug 1520996 - Use AccessorType instead of JSOP for getters/setters.

This will take a very slight memory regression until JSOP is entirely
removed from ParseNode (which will regain a lot more memory).

Comment 2

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/579548b422c6