1521092 - ARM64: Assertion failed: got 5, expected 4 at _[0] (basic/array-copyWithin.js)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Codegen Spew: Output the name of the CacheIR functions.

This patch adds a bunch more context information to CacheIR generated code, by
displaying the name of the function like we already do with the LIR instruction
name in IonMonkey.

I would not have been able to locate the issue without this patch.

Comment 2

[Nicolas B. Pierron [:nbp]]

Attachment: ARM64: pop(FloatRegister) use ARMFPRegister instead of the register code.

The issue was that CacheIRCompiler::emitGuardIsInt32Index would, only in the
IonMonkey case, push and pop a Float register on the stack.

The problem was that that MacroAssemblerCompat::pop(FloatRegister) was
implemented using the register code instead of using the ARMFPRegister
constructor which does the conversion from FloatRegister to an ARMFPRegister.

Therefore, we poped the doubled value in the x0 register instead of popping the
value in d0, erasing the previous value and causing either differential
behaviours or crashes.

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 9038607 [details] [diff] [review]
ARM64: pop(FloatRegister) use ARMFPRegister instead of the register code.

Review of attachment 9038607 [details] [diff] [review]:
-----------------------------------------------------------------

Argh. What a footgun.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

The codegen spew patch needs rebasing.

Comment 5

[Chris Peterson [:cpeterson]]

[arm64:m3] because we should fix reproducible test crashes before letting ARM64 Fennec Nightly ride the trains to Beta.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35d94075e745
Codegen Spew: Output the name of the CacheIR functions. r=sstangl
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c28047982f2
ARM64: pop(FloatRegister) use ARMFPRegister instead of the register code. r=sstangl

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/35d94075e745
https://hg.mozilla.org/mozilla-central/rev/9c28047982f2