1521095 - Crash in core::option::expect_failed | webrender::resource_cache::ResourceCache::get_cached_image

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-71c26bbf-9bbb-46f6-9a53-7a17a0190118.

I hit this crash twice so far today using Mac nightly build 20190118094042:

1. Have an Apple dongle plugged into my MBP
2. Unplug a Countour mouse from the USB port
3. Receive this crash

It is 100% reproducible and takes the entire browser down.

Top 10 frames of crashing thread:

0 XUL MOZ_CrashOOL mfbt/Assertions.h:314
1 XUL GeckoCrashOOL toolkit/xre/nsAppRunner.cpp:4873
2 XUL gkrust_shared::panic_hook toolkit/library/rust/shared/lib.rs:232
3 XUL core::ops::function::Fn::call libcore/ops/function.rs:78
4 XUL std::panicking::rust_panic_with_hook src/libstd/panicking.rs:480
5 XUL std::panicking::continue_panic_fmt src/libstd/panicking.rs:390
6 XUL rust_begin_unwind src/libstd/panicking.rs:325
7 XUL core::panicking::panic_fmt src/libcore/panicking.rs:77
8 XUL core::option::expect_failed src/libcore/option.rs:1008
9 XUL webrender::resource_cache::ResourceCache::get_cached_image gfx/wr/webrender/src/resource_cache.rs

Comment 1

[Marcia Knous [:marcia]]

The adapter I am using is https://www.apple.com/shop/product/MJ1K2AM/A/usb-c-digital-av-multiport-adapter. In Step 2 it is a Contour mouse (incorrect spelling of the name).

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly 67, or potentially, in beta 66 for this.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I don't expect we'll get around to looking at this for 67 as it looks like it's mac only

Comment 4

[Marcia Knous [:marcia]]

This is now happening consistently to me when I check for Apple updates. Right after I select the Apple menu item, I get the Nightly crash reporter. Currently running ahead on 10.14.4 (18E174f).

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Having a fix to bug 1398533 would help diagnosing this.

Comment 6

[Darkspirit]

Didn't find a cached resource with that ID!

Comment 7

[Neha Kochar [:neha]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)

I don't expect we'll get around to looking at this for 67 as it looks like it's mac only

Jeff, there is a crash reported on win10 too. Is this something that can be fixed in 67?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

I don't think the volume is high enough for us to worry about for 67

Comment 9

[Marcia Knous [:marcia]]

This is now crashing for every time I check for an Apple update.

Comment 10

[Marcia Knous [:marcia]]

This is still happening using recent 10.14.5 builds using the steps from Comment 9. The only difference is the signature appears to have changed to [@ GeckoCrash ] - See https://crash-stats.mozilla.org/report/index/047bfc5d-86ef-48d6-97e4-7c26c0190429 for one of my recent crashes.

Comment 12

[Marcia Knous [:marcia]]

Running 10.14.6, I still the slight shift in the window size when I check for Mac updates. But so far I haven't been able to generate another crash yet.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix in 68 , very low volume so I'm marking this fix-optional for 69 as well.

Comment 14

[Wayne Mery (:wsmwk)]

Crash rate dropped significantly, to near zero, end of April
https://crash-stats.mozilla.org/signature/?signature=core%3A%3Aoption%3A%3Aexpect_failed%20%7C%20webrender%3A%3Aresource_cache%3A%3AResourceCache%3A%3Aget_cached_image&date=%3E%3D2021-04-04T03%3A45%3A00.000Z&date=%3C2021-10-04T03%3A45%3A00.000Z#graphs

bp-1df09261-dac2-47be-8497-192b60211001 FF 93

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.