Closed Bug 1521119 Opened 2 years ago Closed 2 years ago

finish/correct implementation of individual horizontal rules above ds-list items

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Status
firefox66 --- fixed

People

(Reporter: dmose, Assigned: dmose)

References

Details

(Keywords: github-merged)

User Story

How to test: 

* go to about:config
* search for stream.config
* set that preference to 
{"enabled":true,"show_spocs":true,"layout_endpoint":"https://gist.githubusercontent.com/dmose/80455b1826e7026abd488ec88d65afc4/raw/0305a22091bd98321867825f370ca609b37ee5cc/gistfile1.txt"}
* open a new tab
* press command (or control, windows) f to open the find bar
* click "whole words"
* enter "list" into the find bar

For the first list that comes up, make sure it has the right set of horizontal bars corresponding to the title.  Which is to say, borderless lists should have none, every other list should have a horizontal bar above each of the stories (the top row will have a single horizontal bar all the away across, all other rows will have one bar per story).

* press command (or control on windows) g to find the next list and verify that.  * repeat until you've gone through all the lists in the document.

Known bugs are already captured as dependents of the ds-list-component bug: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1514020&hide_resolved=0

Attachments

(1 file)

Right now, they sometimes appear where they shouldn't, and are missing where they should be.

Priority: -- → P1
Assignee: nobody → dmose

wolasi also noticed that the whitespace below the first line seems to be smaller than the whitespace below the other item separators

Keywords: github-merged
Blocks: 1522752
User Story: (updated)

Bug 1522875 has been spun off to implement specific desired behavior for unbalanced rows, as mentioned in the review.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
User Story: (updated)
User Story: (updated)
Blocks: 1524048

Numbers are seen under Lists even with the new end-point.

Tracking bug here : bug 1524048

Flags: needinfo?(dmose)
User Story: (updated)
Flags: needinfo?(dmose)

QA Results:

Tested on :

FF Nightly version : 67.0a1 (2019-01-31) (64-bit)
OS : Mac and Windows 10 Pro

Verified bug 1524048

Works as expected.

Closing as verified.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.