Closed Bug 1521132 Opened 5 years ago Closed 5 years ago

Refactor maybeInjectSpocs into selectLayoutRender.js

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4686
52 bytes, text/x-github-pull-request
Details | Review

Right now the maybeInjectSpocs function is in DiscoveryStreamBase, which it is probably better moved into selectLayoutRender.js

Assignee: nobody → sdowne
Severity: normal → enhancement
Iteration: --- → 66.3 - Jan 7 - 20
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/6e20881656b31d469aad56e2276ecfa515a463bf
Bug 1521132 - Combine spoc rendering functions into selectLayoutRender.js (#4686)
Blocks: 1521836
Keywords: github-merged
Iteration: 66.3 - Jan 7 - 20 → 66.4 - Jan 21 - 27

https://hg.mozilla.org/mozilla-central/rev/5f9e44c1bbd5

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Hi,
Can you pls update QA steps, thanks.

Flags: needinfo?(sdowne)

No QA steps required.

Status: RESOLVED → VERIFIED
Flags: needinfo?(sdowne)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: